flake8
passed.
JSHint
passed.
Expand the Local Site query checks in the Users datagrid tests.
Review Request #13360 — Created Oct. 22, 2023 and submitted
This splits most of the unit tests in the Users datagrid test suite into
a global site test, a Local Site test, and a global site + Local Sites
in the database test.This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.There's also a little bit of base class test setup, teardown, and
utilities that are introduced that will be needed for the test query
work.
Unit tests pass.
| Summary | ID |
|---|---|
| 2e4898394d70918b7e9e159387a32096570bdcbf |
- Change Summary:
-
- Added missing documentation.
- Removed some redundant, conflicting test setup/teardown in
test_dashboard.pythat was moved into the base classes.
- Description:
-
This splits most of the unit tests in the Users datagrid test suite into
a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries. + + There's also a little bit of base class test setup, teardown, and
+ utilities that are introduced that will be needed for the test query + work. - Commits:
-
Summary ID bfade44c21c9d4b22bc81e02b83934a8a2ff4225 2e4898394d70918b7e9e159387a32096570bdcbf
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
