Summary

Split the datagrid unit tests into per-suite modules.

Review Request #13359 — Created Oct. 22, 2023 and submitted Oct. 25, 2023, 9:43 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Blocks

13360

Reviewers

Groups

reviewboard

People

Description

The reviewboard.datagrids unit tests were all contained in a single
large tests.py. Some work is being done to audit and optimize queries
for the datagrid, which will significantly grow this test suite.

To prepare for that work, this change splits up the test suite into a
file for each tested datagrid and for each tested column.

No code changes have been made to the test suites, with the exception
that two suites were merged together, as they were testing the same
datagrid.

Testing Done

Unit tests pass.

Commits

Summary	ID
Split the datagrid unit tests into per-suite modules. The `reviewboard.datagrids` unit tests were all contained in a single large `tests.py`. Some work is being done to audit and optimize queries for the datagrid, which will significantly grow this test suite. To prepare for that work, this change splits up the test suite into a file for each tested datagrid and for each tested column. No code changes have been made to the test suites.	09b82e1e6812fca050a793ef344dfada16693a03

Summary

Split the datagrid unit tests into per-suite modules.

The `reviewboard.datagrids` unit tests were all contained in a single large `tests.py`. Some work is being done to audit and optimize queries for the datagrid, which will significantly grow this test suite. To prepare for that work, this change splits up the test suite into a file for each tested datagrid and for each tested column. No code changes have been made to the test suites.

09b82e1e6812fca050a793ef344dfada16693a03

Issues

Description	From	Last Updated
redefinition of unused 'ReviewRequest' from line 20 Column: 1 Error code: F811	reviewbot	Oct. 22, 2023, 1:04 p.m.
'kgb' imported but unused Column: 1 Error code: F401	reviewbot	Oct. 22, 2023, 1:04 p.m.
'django.core.cache.cache' imported but unused Column: 1 Error code: F401	reviewbot	Oct. 22, 2023, 1:04 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests/test_dashboard.py (Diff revision 1)
The issue has been resolved. Show all issues
```
redefinition of unused 'ReviewRequest' from line 20

Column: 1
Error code: F811
```
reviewboard/datagrids/tests/test_groups_list.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'kgb' imported but unused

Column: 1
Error code: F401
```
reviewboard/datagrids/tests/test_users_list.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.core.cache.cache' imported but unused

Column: 1
Error code: F401
```

Change Summary:


Removed unused imports.

Description:

		The `reviewboard.datagrids` unit tests were all contained in a single
		large `tests.py`. Some work is being done to audit and optimize queries
		for the datagrid, which will significantly grow this test suite.

		To prepare for that work, this change splits up the test suite into a
		file for each tested datagrid and for each tested column.

~		No code changes have been made to the test suites.
	~	No code changes have been made to the test suites, with the exception
	+	that two suites were merged together, as they were testing the same
	+	datagrid.

Commits:

	Summary	ID
	Split the datagrid unit tests into per-suite modules. The `reviewboard.datagrids` unit tests were all contained in a single large `tests.py`. Some work is being done to audit and optimize queries for the datagrid, which will significantly grow this test suite. To prepare for that work, this change splits up the test suite into a file for each tested datagrid and for each tested column. No code changes have been made to the test suites.	917b39fd65e62cc6d072edd78b48b32bf3c8d62b
	Split the datagrid unit tests into per-suite modules. The `reviewboard.datagrids` unit tests were all contained in a single large `tests.py`. Some work is being done to audit and optimize queries for the datagrid, which will significantly grow this test suite. To prepare for that work, this change splits up the test suite into a file for each tested datagrid and for each tested column. No code changes have been made to the test suites.	09b82e1e6812fca050a793ef344dfada16693a03

Diff:

Revision 2 (+7676 -7460)

Show changes

	reviewboard/datagrids/tests.py
	reviewboard/datagrids/tests/__init__.py
	reviewboard/datagrids/tests/base.py
	reviewboard/datagrids/tests/test_all_review_requests.py
	reviewboard/datagrids/tests/test_dashboard.py
	reviewboard/datagrids/tests/test_full_name_column.py
	reviewboard/datagrids/tests/test_groups_list.py
	reviewboard/datagrids/tests/test_ship_it_column.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (ab91723)