Summary

Expand the Local Site query checks in the Dashboard tests.

Review Request #13363 — Created Oct. 22, 2023 and submitted Oct. 27, 2023, 6:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

~~13360~~

Blocks

13365

Reviewers

Groups

reviewboard

People

Description

This splits most of the unit tests in the Dashboard test suite into a
global site test, a Local Site test, and a global site + Local Sites in
the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Testing Done

Unit tests pass.

Commits

Summary	ID
Expand the Local Site query checks in the Dashboard tests. This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	eb0ecc2680f3d36ae4b3289740a9e7db0d5786b6

Summary

Expand the Local Site query checks in the Dashboard tests.

This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.

eb0ecc2680f3d36ae4b3289740a9e7db0d5786b6

Issues

Description	From	Last Updated
continuation line over-indented for visual indent Column: 34 Error code: E127	reviewbot	Oct. 22, 2023, 5:10 p.m.
local variable 'local_site_q' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 22, 2023, 5:11 p.m.
local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 22, 2023, 5:11 p.m.
local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 22, 2023, 5:11 p.m.
local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 22, 2023, 5:12 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests/test_dashboard.py (Diff revision 1)
The issue has been resolved. Show all issues
```
continuation line over-indented for visual indent

Column: 34
Error code: E127
```
reviewboard/datagrids/tests/test_dashboard.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'local_site_q' is assigned to but never used

Column: 13
Error code: F841
```

reviewboard/datagrids/tests/test_dashboard.py (Diff revision 1)

The issue has been resolved. Show all issues

local variable 'target_groups_local_site_q' is assigned to but never used

Column: 13
Error code: F841

reviewboard/datagrids/tests/test_dashboard.py (Diff revision 1)

The issue has been resolved. Show all issues

local variable 'target_groups_local_site_q' is assigned to but never used

Column: 13
Error code: F841

Change Summary:


Fixed an alignment issue.
Removed unused variables.

Commits:

	Summary	ID
	Expand the Local Site query checks in the Dashboard tests. This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	9400acd366daaf17b808be32fd68f11708bcbf77
	Expand the Local Site query checks in the Dashboard tests. This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	867b26c45b66e6d5754c41b4bfa19439c6fdc334

Diff:

Revision 2 (+4726 -1048)

Show changes

reviewboard/datagrids/tests/test_dashboard.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests/test_dashboard.py (Diff revision 2)

The issue has been resolved. Show all issues

local variable 'target_groups_local_site_q' is assigned to but never used

Column: 13
Error code: F841

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Expand the Local Site query checks in the Dashboard tests. This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	867b26c45b66e6d5754c41b4bfa19439c6fdc334
	Expand the Local Site query checks in the Dashboard tests. This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	eb0ecc2680f3d36ae4b3289740a9e7db0d5786b6

Diff:

Revision 3 (+4720 -1048)

Show changes

reviewboard/datagrids/tests/test_dashboard.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (310ce54)