Expand the Local Site query checks in the Dashboard tests.

Review Request #13363 — Created Oct. 22, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

This splits most of the unit tests in the Dashboard test suite into a
global site test, a Local Site test, and a global site + Local Sites in
the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Unit tests pass.

Summary ID
Expand the Local Site query checks in the Dashboard tests.
This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
eb0ecc2680f3d36ae4b3289740a9e7db0d5786b6
Description From Last Updated

continuation line over-indented for visual indent Column: 34 Error code: E127

reviewbotreviewbot

local variable 'local_site_q' is assigned to but never used Column: 13 Error code: F841

reviewbotreviewbot

local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841

reviewbotreviewbot

local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841

reviewbotreviewbot

local variable 'target_groups_local_site_q' is assigned to but never used Column: 13 Error code: F841

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:
  • Fixed an alignment issue.
  • Removed unused variables.
Commits:
Summary ID
Expand the Local Site query checks in the Dashboard tests.
This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
9400acd366daaf17b808be32fd68f11708bcbf77
Expand the Local Site query checks in the Dashboard tests.
This splits most of the unit tests in the Dashboard test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
867b26c45b66e6d5754c41b4bfa19439c6fdc334

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (310ce54)