Summary

Expand the Local Site query checks in the All Review Requests datagrid tests.

Review Request #13361 — Created Oct. 22, 2023 and submitted Oct. 27, 2023, 6:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

~~13360~~

Reviewers

Groups

reviewboard

People

Description

This splits most of the unit tests in the All Review Requests datagrid
test suite into a global site test, a Local Site test, and a global
site + Local Sites in the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Testing Done

Unit tests pass.

Commits

Summary	ID
Expand the Local Site query checks in the All Review Requests datagrid tests. This splits most of the unit tests in the All Review Requests datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	b8ef11b6584366f94b216674e4e8f8fa3b224379

Summary

Expand the Local Site query checks in the All Review Requests datagrid tests.

This splits most of the unit tests in the All Review Requests datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.

b8ef11b6584366f94b216674e4e8f8fa3b224379

flake8 passed.

JSHint passed.

Change Summary:

Fixed docs to reference the "All Review Requests" datagrid instead of the users datagrid.

Commits:

	Summary	ID
	Expand the Local Site query checks in the All Review Requests datagrid tests. This splits most of the unit tests in the All Review Requests datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	8639b88fd9a93fd9f3a22b18e997b924e4cf0a26
	Expand the Local Site query checks in the All Review Requests datagrid tests. This splits most of the unit tests in the All Review Requests datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	b8ef11b6584366f94b216674e4e8f8fa3b224379

Diff:

Revision 2 (+1880 -104)

Show changes

reviewboard/datagrids/tests/test_all_review_requests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (d3ceeee)