Expand the Local Site query checks in the All Review Requests datagrid tests.

Review Request #13361 — Created Oct. 22, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

This splits most of the unit tests in the All Review Requests datagrid
test suite into a global site test, a Local Site test, and a global
site + Local Sites in the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Unit tests pass.

Summary ID
Expand the Local Site query checks in the All Review Requests datagrid tests.
This splits most of the unit tests in the All Review Requests datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.
b8ef11b6584366f94b216674e4e8f8fa3b224379
chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (d3ceeee)