Summary:

[WIP] Add web-based logon.

Review Request #12981 — Created May 5, 2023 and updated May 5, 2023, 11:43 a.m.

Information
Owner:	maubin
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

This adds web-based logon for to RBTools. This allows users of RBTools to
authenticate to the Review Board server via a web browser. This is useful for
users who authenticate to Review Board using SSO or similar methods, and would
like to use those methods to authenticate to RBTools. To do this we spin up a
local server which redirects to Review Board's login page and then stores the
authentication data received from the Review Board server.

This currently relies on receiving session cookie data from Review Board for
authentication, but I will be changing it so that we use API tokens instead.

Testing Done


Ran unit tests.
Manually tested the login flow with successful logins and failed logins.
Tested logging in again while logged in and logging out

Commits

Summary
Add web based login.

Screenshots

Issues

Description	From	Last Updated
I'm not sure of how I should add unit tests for this request handler. I'm not sure how to mock …	maubin	May 9, 2023, 3:01 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	May 11, 2023, 3:22 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/utils/web_login_server.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

rbtools/utils/web_login_server.py (Diff revision 1)

Show all issues

I'm not sure of how I should add unit tests for this request handler. I'm not sure how to mock an HTTPServer in order to test things, or if I should just run a server on localhost:8000 or something during the tests.