rbtools/utils/web_login_server.py (Diff revision 1)Show all issues
Review Request #12981 — Created May 5, 2023 and updated
This adds web-based logon for to RBTools. This allows users of RBTools to
authenticate to the Review Board server via a web browser. This is useful for
users who authenticate to Review Board using SSO or similar methods, and would
like to use those methods to authenticate to RBTools. To do this we spin up a
local server which redirects to Review Board's login page and then stores the
authentication data received from the Review Board server.
This currently relies on receiving session cookie data from Review Board for
authentication, but I will be changing it so that we use API tokens instead.
|rbtools/utils/web_login_server.py (Diff revision 1)|
I'm not sure of how I should add unit tests for this request handler. I'm not sure how to mock an
HTTPServerin order to test things, or if I should just run a server on localhost:8000 or something during the tests.