Summary

Make the user agent accessible from the RBClient class.

Review Request #13340 — Created Oct. 13, 2023 and updated Oct. 25, 2023, 12:40 p.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Blocks

12981

Reviewers

Groups

rbtools

People

Description

This makes the user agent string used for clients accessible from RBClient
as a property. We also weren't passing on the user agent from SyncTransport
to the ReviewBoardServer, so if a custom agent was set on the
SyncTransport, the ReviewBoardServer would still use the default agent.
This change fixes that.

Testing Done


Ran unit tests.
Used in an upcoming change where I access the user agent from the

RBClient in a command.

Commits

Summary	ID
Make the user agent accessible from the RBClient class.	570dd14ab268f54ba50406217f609d5cc0d84526

Issues

Description	From	Last Updated
Can we call this user_agent instead? agent is pretty generic.	david	Oct. 16, 2023, 11:14 a.m.

flake8 passed.

JSHint passed.

rbtools/api/client.py (Diff revision 1)

Show all issues

Can we call this user_agent instead? agent is pretty generic.

Commits:

	Summary	ID
	Make the user agent accessible from the RBClient class.	09989f08d54a046505caa24cd4b43c7336854bd0
	Make the user agent accessible from the RBClient class.	053625b9815afd9efe69d1bf5c331a35b5bfe03b

Diff:

Revision 2 (+38 -4)

Show changes

	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Forgot to actually switch to the user_agent variable instead of agent.

Commits:

	Summary	ID
	Make the user agent accessible from the RBClient class.	053625b9815afd9efe69d1bf5c331a35b5bfe03b
	Make the user agent accessible from the RBClient class.	570dd14ab268f54ba50406217f609d5cc0d84526

Diff:

Revision 3 (+38 -4)

Show changes

	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```