Added difference viewer for XML files.

Review Request #10713 — Created Sept. 11, 2019 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

There is now a syntax highlighted rendered view for XML files, where each node
in the XML document will be consistently indented so that it is easy to see
the actual contents of the document, even if the document is minified or
improperly formatted.

Unicode characters will be properly displayed in the render view as well.

There is also support for comparing different XML files with either the
render view or normal text view.

1) Ran unit tests on Python 2.7 and 3.6.
2) Tested manually on Python 2.7 and 3.6 outside of the diff viewer.
3) Tested manually on Python 2.7 and 3.6 inside of the diff viewer.
4) Tested manually on Python 2.7 and 3.6 with a document with UTF-8 encoding
and characters.
5) Tested manually on Python 2.7 and 3.6 with an invalid XML document that
leads to an error while parsing.

Changes between revision 7 and 8

orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20

Commits

Summary ID Author
Added difference viewer for XML files.
4b00ace6633843b71d42d9d9ed350e01c0753d0f amalik2
fixed more review bot errors
7504cd5892d3b2c4781f8f3b0c4f1e6de4c52727 amalik2
fixed even more errors
52deed060ab050d79c0282f45344abbd9e36be39 amalik2
added checkbox to toggle same line rendering for text
ffe660445fc00bf34725d9d1cf53cf2d9d6437b6 amalik2
fixes
51141a347518df7dac12c0d62c87dafa8ffa8a17 amalik2
more fixes
96b46f1688a9b07b5f9146677e6be398b015bc71 amalik2
fixed over identation?
2e37cf09f1cef4e9b7f5a05d65cb1a4d616d90c9 amalik2
reviewboard/reviews/tests/test_xml_review_ui.py
reviewboard/reviews/ui/xmlui.py
Loading...