Summary

WIP: Dynamic Review UI Rendering

Review Request #10758 — Created Oct. 20, 2019 and updated Dec. 2, 2019, 11:15 p.m.

Information

Owner

nicolelisa

Repository

Review Board

Branch

master

Bugs

Depends On

Blocks

10713

Reviewers

Groups

reviewboard, students

People

Description

Overview:

Add in functionality to allow review UIs to provide a list of (relative) URLs they want to register, along with the methods that will be handling requests to those URLs.

Task specifications can be found here

This task has been separated into 4 subtasks:

1. Base(1): Review UI URLs - Adding the ability for a ReviewUI subclass to provide URLs they want to make available. Assigned to Nicole.
2. Text(1): Built-In Render URLs - Adding a standard _render/ URL for TextBasedReviewUI. This would ultimately take a type= argument specifying (source or rendered), which could be passed by the caller. Assigned to Nicole.
3. Text(2): Rendering Options Template Block - Update reviewboard/templates/reviews/ui/text.html template to provide a {% block "render_options" %} that subclasses of the template can use to add new UI. This would be blank by default, meaning it's entirely optional, and can be used only by the review UIs that need it. Assigned to Adil.
4. Text(3): Render Requests in JavaScript - Wrap RB.apiCall in a new method to provide Review UIs with the ability to make requests for custom rendering options and backend rendering implementations. Assigned to Adil

Testing Done

Adil's Testing for Tasks 3 and 4:

Ran JavaScript unit tests.
Tested manually to make sure that the element to update actually gets

updated by using a mock endpoint.
Tested manually to make sure comments are correctly reattached after

a request is finished.

Commits

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	bbac6f795332fbebc83b8392ecc3213b86f58ab2	nicolelisa
Add in Adil's 'Added function to reload render options with AJAX' - Review Request #10749	179716bc369fae4f98b62ebd30ef2f858e87f974	nicolelisa
reviewbot changes	cfebbba9ebc36d2fad99b5d2f88844892a0ec284	nicolelisa
Changed enpoint for ajax request to point to TextBasedReviewUIView url	20b38c6b129876ce9714e3a13672182c88fa8866	nicolelisa
Renamed TextBasedReviewUIView to TextBasedReviewUITextView	fad657c963f5bdf9b98f38eaa802fa033591c203	nicolelisa
Added in Review Request #10731 changes completed by Adil	b2bef6b73d110507856bf81618e48a846ccc79ec	nicolelisa
Add dummy features for the Ajax functionality	8db350412c01e143b1d21654493f7667b80ea218	nicolelisa

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	Oct. 27, 2019, 10:32 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 27, 2019, 10:32 a.m.
F401 'django.conf.urls.include' imported but unused	reviewbot	Oct. 27, 2019, 11:20 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 27, 2019, 11:21 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 27, 2019, 11:21 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 27, 2019, 11:21 a.m.
F401 'django.core.urlresolvers.reverse_lazy' imported but unused	reviewbot	Oct. 27, 2019, 11:22 a.m.
F401 'django.core.urlresolvers.reverse' imported but unused	reviewbot	Oct. 27, 2019, 11:22 a.m.
F401 'django.http.Http404' imported but unused	reviewbot	Nov. 8, 2019, 4:16 p.m.
F401 'django.core.urlresolvers.resolve' imported but unused	reviewbot	Nov. 8, 2019, 4:16 p.m.
F401 'django.db.models.Q' imported but unused	reviewbot	Nov. 8, 2019, 4:17 p.m.
F401 'django.http.Http404' imported but unused	reviewbot	Nov. 8, 2019, 4:17 p.m.
F401 'django.http.HttpResponseForbidden' imported but unused	reviewbot	Nov. 13, 2019, 4:51 p.m.
F401 'django.core.urlresolvers.resolve' imported but unused	reviewbot	Nov. 8, 2019, 4:17 p.m.
F401 'django.db.models.Q' imported but unused	reviewbot	Nov. 8, 2019, 4:17 p.m.
F401 'django.shortcuts.get_object_or_404' imported but unused	reviewbot	Nov. 8, 2019, 4:17 p.m.
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused	reviewbot	Nov. 13, 2019, 4:55 p.m.
This shouldn't be staticmethod and should be the get method, ie def get(self, ...):	brennie	Nov. 8, 2019, 4:18 p.m.
Once ReviewFileAttachmentViewMixin is not using staticmethods, this should just be self.get_attachments, etc.	brennie	Nov. 8, 2019, 4:19 p.m.
Here too	brennie	Nov. 8, 2019, 4:19 p.m.
F841 local variable 'review_ui' is assigned to but never used	reviewbot	Nov. 13, 2019, 4:55 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 13, 2019, 4:55 p.m.
This should be TextBasedReviewUIView.as_view()	brennie	Nov. 8, 2019, 4:21 p.m.
These should not be staticmethods; these should be regular methods instead.	brennie	Nov. 8, 2019, 4:22 p.m.
These should not be staticmethods; these should be regular methods instead.	brennie	Nov. 8, 2019, 4:22 p.m.
F841 local variable 'review_ui' is assigned to but never used	reviewbot	Nov. 13, 2019, 5:04 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 13, 2019, 5:04 p.m.
In addition to these new tests, you should also have tests that assert that unregistering the review UI has the …	amalik2	Nov. 13, 2019, 8:37 p.m.
This import statement should probably be moved to the top of this file for consistency.	amalik2	Nov. 22, 2019, 4:52 p.m.
Is there any way this can be done without modifying a global variable in another file? If there isn't, then …	amalik2	Nov. 13, 2019, 8:37 p.m.
This import statement should probably be moved to the top of this file for consistency.	amalik2	Nov. 14, 2019, 6:43 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'djblets.webapi.resources.WebAPIResource' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'django.views.generic.base.ContextMixin' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'django.views.generic.base.TemplateView' imported but unused	reviewbot	Nov. 13, 2019, 5:05 p.m.
F401 'django.views.generic.base.RedirectView' imported but unused	reviewbot	Nov. 13, 2019, 5:06 p.m.
F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused	reviewbot	Nov. 13, 2019, 5:06 p.m.
You should write some tests to make sure that this method works as expected	amalik2	Nov. 22, 2019, 4:57 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 16, 2019, 3:31 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2019, 3:32 p.m.
Is kwargs meant to be used by individual review UIs in the future? I think all of the query parameter …	amalik2	Nov. 22, 2019, 4:57 p.m.
Just curious about this, how can specific review UIs like the JSON or XML ones render text in different ways …	amalik2	Nov. 22, 2019, 4:57 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Nov. 16, 2019, 3:32 p.m.
F841 local variable 'review_ui' is assigned to but never used	reviewbot	Nov. 13, 2019, 5:07 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 13, 2019, 5:07 p.m.
F401 'django.db.models.Q' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.shortcuts.get_object_or_404' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.http.Http404' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.shortcuts.render_to_response' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.views.generic.base.View' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F811 redefinition of unused 'ReviewFileAttachmentViewMixin' from line 76	reviewbot	Nov. 16, 2019, 3:31 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2019, 3:31 p.m.
F841 local variable 'is_enabled_for' is assigned to but never used	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.http.HttpResponseNotFound' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.http.HttpResponseBadRequest' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.shortcuts.get_list_or_404' imported but unused	reviewbot	Nov. 16, 2019, 3:31 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Nov. 16, 2019, 3:31 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 16, 2019, 3:31 p.m.
W391 blank line at end of file	reviewbot	Nov. 16, 2019, 3:31 p.m.
F401 'django.db.models.Q' imported but unused	reviewbot	Nov. 22, 2019, 4:57 p.m.
F401 'django.shortcuts.get_object_or_404' imported but unused	reviewbot	Nov. 22, 2019, 4:57 p.m.
F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused	reviewbot	Nov. 22, 2019, 4:58 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 22, 2019, 5:01 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 22, 2019, 5:02 p.m.
F401 'django.http.Http404' imported but unused	reviewbot	Nov. 22, 2019, 5:02 p.m.
F401 'django.shortcuts.render_to_response' imported but unused	reviewbot	Nov. 22, 2019, 5:02 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 22, 2019, 5:03 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 22, 2019, 5:03 p.m.
F401 'django.http.HttpResponseBadRequest' imported but unused	reviewbot	Nov. 22, 2019, 5:03 p.m.
F401 'django.http.HttpResponseNotFound' imported but unused	reviewbot	Nov. 22, 2019, 5:03 p.m.
F401 'django.shortcuts.get_list_or_404' imported but unused	reviewbot	Nov. 22, 2019, 5:03 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 22, 2019, 5:04 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Nov. 22, 2019, 5:04 p.m.
W391 blank line at end of file	reviewbot	Nov. 22, 2019, 5:04 p.m.
F401 'django.db.models.Q' imported but unused	reviewbot	Nov. 22, 2019, 5:04 p.m.
F401 'django.shortcuts.get_object_or_404' imported but unused	reviewbot	Nov. 22, 2019, 5:04 p.m.
F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused	reviewbot	Nov. 22, 2019, 5:04 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 22, 2019, 5:04 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.http.Http404' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.shortcuts.render_to_response' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.http.HttpResponseBadRequest' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.http.HttpResponseNotFound' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
F401 'django.shortcuts.get_list_or_404' imported but unused	reviewbot	Nov. 22, 2019, 5:05 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 22, 2019, 5:05 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Nov. 22, 2019, 5:05 p.m.
W391 blank line at end of file	reviewbot	Nov. 22, 2019, 5:05 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 23, 2019, 4:59 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Nov. 23, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Nov. 23, 2019, 4:58 p.m.
This should be removed, I've removed it from my AJAX function review request now as well	amalik2	Dec. 2, 2019, 11:15 p.m.
This should be removed, I've removed it from my AJAX function review request now as well	amalik2	Dec. 2, 2019, 11:15 p.m.
This should be removed, I've removed it from my AJAX function review request now as well	amalik2	Dec. 2, 2019, 11:15 p.m.
This should be removed, I've removed it from my AJAX function review request now as well	amalik2	Dec. 2, 2019, 11:15 p.m.
All changes to this file should be reverted since they were just for testing purposes	amalik2	Dec. 2, 2019, 11:15 p.m.
F401 'django.http.HttpResponse' imported but unused	reviewbot	Dec. 2, 2019, 3:38 p.m.
F401 'django.utils.safestring.mark_safe' imported but unused	reviewbot	Dec. 2, 2019, 3:38 p.m.
F401 'djblets.util.compat.django.template.loader.render_to_string' imported but unused	reviewbot	Dec. 2, 2019, 3:38 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This isn't too important but technically this should be an HTTP 400 error. 404 indicates the resource was not found, …	amalik2	Dec. 2, 2019, 11:15 p.m.
This will need to be slightly modified to handle diff chunks, since those aren't stored using context['rendered_lines'] or context['text_lines']	amalik2	Dec. 2, 2019, 11:15 p.m.
In my XML review request I had to set context['lines'] to the result of the generate_render() function to bypass the …	amalik2	Dec. 2, 2019, 11:15 p.m.
This should be context['lines'] = context['text_lines']	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This should either be implemented and used in some way or removed	amalik2	Dec. 2, 2019, 11:15 p.m.
Maybe a different name for this key would be more suitable? It may not be that intuitive to others what …	amalik2	Dec. 2, 2019, 11:15 p.m.
This comment should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This comment should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This isn't important for this review request but in my AJAX function review request, there was a check for whether …	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
The docstring should be modified to include the 'renderType' parameter since you are using it	amalik2	Dec. 2, 2019, 11:15 p.m.
This should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.
This test code should be removed	amalik2	Dec. 2, 2019, 11:15 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E402 module level import not at top of file
```
reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa

Diff:

Revision 2 (+290 -22)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_file_attachment_review_ui.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'django.conf.urls.include' imported but unused
```
reviewboard/reviews/tests/test_file_attachment_review_ui.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_file_attachment_review_ui.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_file_attachment_review_ui.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/ui/base.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'django.core.urlresolvers.reverse_lazy' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'django.core.urlresolvers.reverse' imported but unused
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa

Diff:

Revision 3 (+293 -27)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	3f69a1f00c9303084d1d89fe47bc622472df4c71	nicolelisa

Diff:

Revision 4 (+375 -39)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/text.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'django.core.urlresolvers.resolve' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'django.db.models.Q' imported but unused
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	3f69a1f00c9303084d1d89fe47bc622472df4c71	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	9c9d767c43a41e701165bb4506f2b3a11eec5b49	nicolelisa

Diff:

Revision 5 (+563 -119)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseForbidden' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.core.urlresolvers.resolve' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.db.models.Q' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_object_or_404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F841 local variable 'review_ui' is assigned to but never used
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F841 local variable 'review_ui' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

reviewboard/reviews/ui/text.py (Diff revision 5)

The issue has been resolved. Show all issues

This shouldn't be staticmethod and should be the get method, ie

def get(self, ...):

reviewboard/reviews/ui/text.py (Diff revision 5)

The issue has been resolved. Show all issues

Once ReviewFileAttachmentViewMixin is not using staticmethods, this should just be self.get_attachments, etc.

reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Here too
```
reviewboard/reviews/ui/text.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This should be TextBasedReviewUIView.as_view()
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These should not be staticmethods; these should be regular methods instead.
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These should not be staticmethods; these should be regular methods instead.
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	9c9d767c43a41e701165bb4506f2b3a11eec5b49	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	d71396a9f3efab7725275c2172429aef3e48778b	nicolelisa

Diff:

Revision 6 (+605 -119)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'djblets.webapi.resources.WebAPIResource' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'django.views.generic.base.ContextMixin' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'django.views.generic.base.TemplateView' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'django.views.generic.base.RedirectView' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/reviews/ui/text.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
F841 local variable 'review_ui' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

Fix it!

reviewboard/reviews/tests/test_file_attachment_review_ui.py (Diff revision 6)

An issue was opened. Show all issues

In addition to these new tests, you should also have tests that assert that unregistering the review UI has the expected behaviour.

nicolelisa Nov. 14, 2019, 6:46 p.m.

Hm. I had sworn i wrote this but I must have forgot. thanks for pointing this out!

reviewboard/reviews/ui/base.py (Diff revision 6)

The issue has been resolved. Show all issues

This import statement should probably be moved to the top of this file for consistency.

nicolelisa Nov. 14, 2019, 6:46 p.m.

This was the workaround for the cyclic import statement discussed in the meeting. If you have any other ideas on how to fix this though, that would be really helpful.

reviewboard/reviews/ui/base.py (Diff revision 6)

An issue was opened. Show all issues

Is there any way this can be done without modifying a global variable in another file? If there isn't, then for encapsulation purposes it may be better to have a method in the urls.py file that takes in a urlpatterns argument, and appends it to the dyanmic URL resolver. Something like this:
def add_dynamic_review_ui_urls(urlpatterns):

    ....

reviewboard/reviews/ui/base.py (Diff revision 6)

The issue has been resolved. Show all issues

This import statement should probably be moved to the top of this file for consistency.

reviewboard/reviews/ui/text.py (Diff revision 6)

The issue has been dropped. Show all issues

You should write some tests to make sure that this method works as expected

nicolelisa Nov. 14, 2019, 6:46 p.m.

Structuring of this is still a WIP but that's on the todo list

reviewboard/reviews/ui/text.py (Diff revision 6)

The issue has been dropped. Show all issues

Is kwargs meant to be used by individual review UIs in the future? I think all of the query parameter values are available in the request object, which already gets passed to the review UI

nicolelisa Nov. 14, 2019, 6:46 p.m.

Changing the structure of this part but will take a look at this when it's moved around.

reviewboard/reviews/ui/text.py (Diff revision 6)

The issue has been dropped. Show all issues

Just curious about this, how can specific review UIs like the JSON or XML ones render text in different ways based on the query parameter values? Where should the code that accesses them actually be (i.e. would it be in get_render_lines? If so, wouldn't that function need to be modified to take in a request argument?)

nicolelisa Nov. 14, 2019, 6:46 p.m.

Yeah, we've been discussing this in the #students channel. Moving a bunch of stuff around to hopefully address this.

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	d71396a9f3efab7725275c2172429aef3e48778b	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	d87233dcbfd3bc2acf76d71c38c5afa54f20af0c	nicolelisa

Diff:

Revision 7 (+1241 -631)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.db.models.Q' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_object_or_404' imported but unused
```

reviewboard/reviews/ui/base.py (Diff revision 7)

The issue has been resolved. Show all issues

F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused

reviewboard/reviews/ui/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/ui/text.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.render_to_response' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.views.ReviewFileAttachmentView' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.views.generic.base.View' imported but unused
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'ReviewFileAttachmentViewMixin' from line 76
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F841 local variable 'is_enabled_for' is assigned to but never used
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseNotFound' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseBadRequest' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_list_or_404' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E116 unexpected indentation (comment)
```
reviewboard/reviews/views_mixins.py (Diff revision 7)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
add get_render_mode	d87233dcbfd3bc2acf76d71c38c5afa54f20af0c	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa

Diff:

Revision 8 (+1269 -649)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/base.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.db.models.Q' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_object_or_404' imported but unused
```

reviewboard/reviews/ui/base.py (Diff revision 8)

The issue has been resolved. Show all issues

F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused

reviewboard/reviews/ui/base.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/ui/text.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.render_to_response' imported but unused
```
reviewboard/reviews/views.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseBadRequest' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseNotFound' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_list_or_404' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E116 unexpected indentation (comment)
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/views_mixins.py (Diff revision 8)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa

Diff:

Revision 9 (+1239 -679)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/base.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.db.models.Q' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_object_or_404' imported but unused
```

reviewboard/reviews/ui/base.py (Diff revision 9)

The issue has been resolved. Show all issues

F401 'reviewboard.reviews.views_mixins.ReviewRequestViewMixin' imported but unused

reviewboard/reviews/ui/base.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/ui/text.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/reviews/ui/text.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.render_to_response' imported but unused
```
reviewboard/reviews/views.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseBadRequest' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.http.HttpResponseNotFound' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F401 'django.shortcuts.get_list_or_404' imported but unused
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E116 unexpected indentation (comment)
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/views_mixins.py (Diff revision 9)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	ac31a894d15d2097bfad47231f80cd6226536581	nicolelisa

Diff:

Revision 10 (+1240 -698)

Show changes

	reviewboard/deprecation.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	ac31a894d15d2097bfad47231f80cd6226536581	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	bbac6f795332fbebc83b8392ecc3213b86f58ab2	nicolelisa
Add in Adil's 'Added function to reload render options with AJAX' - Review Request #10749	179716bc369fae4f98b62ebd30ef2f858e87f974	nicolelisa

Diff:

Revision 11 (+1708 -706)

Show changes

	reviewboard/deprecation.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/text.py
	5 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 11)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 11)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/admin/urls.py (Diff revision 11)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```

Summary:

-	WIP: Base: Review UI URLs
+	WIP: Dynamic Review UI Rendering

Description:

~		set up base for review ui urls
	~	Add in functionality to allow review UIs to provide a list of (relative) URLs they want to register, along with the methods that will be handling requests to those URLs.
	+
	+	Task specifications can be found here
	+
	+	This task has been separated into 4 subtasks:
	+	1. Base(1): Review UI URLs - Adding the ability for a ReviewUI subclass to provide URLs they want to make available. Assigned to Nicole.
	+	2. Text(1): Built-In Render URLs - Adding a standard `_render/` URL for `TextBasedReviewUI`. This would ultimately take a `type=` argument specifying (`source` or `rendered`), which could be passed by the caller. Assigned to Nicole.
	+	3. Text(2): Rendering Options Template Block - Update `reviewboard/templates/reviews/ui/text.html` template to provide a `{% block "render_options" %}` that subclasses of the template can use to add new UI. This would be blank by default, meaning it's entirely optional, and can be used only by the review UIs that need it. Assigned to Adil.
	+	4. Text(3): Render Requests in JavaScript - Wrap `RB.apiCall` in a new method to provide Review UIs with the ability to make requests for custom rendering options and backend rendering implementations. Assigned to Adil

Testing Done:

	+	Adil's Testing for Tasks 3 and 4:
	+	1. Ran JavaScript unit tests.
	+	2. Tested manually to make sure that the element to update actually gets
	+	updated by using a mock endpoint.
	+	3. Tested manually to make sure comments are correctly reattached after
	+	a request is finished.

Description:

	+	Overview:
	+
		Add in functionality to allow review UIs to provide a list of (relative) URLs they want to register, along with the methods that will be handling requests to those URLs.

		Task specifications can be found here

~		This task has been separated into 4 subtasks:
~		1. Base(1): Review UI URLs - Adding the ability for a ReviewUI subclass to provide URLs they want to make available. Assigned to Nicole.
	~	This task has been separated into 4 subtasks:
	~
	+	1. Base(1): Review UI URLs - Adding the ability for a ReviewUI subclass to provide URLs they want to make available. Assigned to Nicole.
		2. Text(1): Built-In Render URLs - Adding a standard `_render/` URL for `TextBasedReviewUI`. This would ultimately take a `type=` argument specifying (`source` or `rendered`), which could be passed by the caller. Assigned to Nicole.
		3. Text(2): Rendering Options Template Block - Update `reviewboard/templates/reviews/ui/text.html` template to provide a `{% block "render_options" %}` that subclasses of the template can use to add new UI. This would be blank by default, meaning it's entirely optional, and can be used only by the review UIs that need it. Assigned to Adil.
		4. Text(3): Render Requests in JavaScript - Wrap `RB.apiCall` in a new method to provide Review UIs with the ability to make requests for custom rendering options and backend rendering implementations. Assigned to Adil

Testing Done:

~		Adil's Testing for Tasks 3 and 4:
~		1. Ran JavaScript unit tests.
~		2. Tested manually to make sure that the element to update actually gets
~		updated by using a mock endpoint.
~		3. Tested manually to make sure comments are correctly reattached after
	~	Adil's Testing for Tasks 3 and 4:
	~
	~	Ran JavaScript unit tests.
	~	Tested manually to make sure that the element to update actually gets updated by using a mock endpoint.
	~	Tested manually to make sure comments are correctly reattached after a request is finished.
-		a request is finished.

Commits:

Summary	ID	Author
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	bbac6f795332fbebc83b8392ecc3213b86f58ab2	nicolelisa
Add in Adil's 'Added function to reload render options with AJAX' - Review Request #10749	179716bc369fae4f98b62ebd30ef2f858e87f974	nicolelisa
set up base for review ui urls	8321ecb908f20b49eb2268770c82695e3369ddb0	nicolelisa
add testing and fix patterns	db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9	nicolelisa
reviewbot changes	e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025	nicolelisa
wip for url rendering with ajax started	9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d	nicolelisa
revert html changes to rendering	ac92785154c3b11ffca422967cc093a3196da6e8	nicolelisa
reviewbot changes	bbac6f795332fbebc83b8392ecc3213b86f58ab2	nicolelisa
Add in Adil's 'Added function to reload render options with AJAX' - Review Request #10749	179716bc369fae4f98b62ebd30ef2f858e87f974	nicolelisa
reviewbot changes	cfebbba9ebc36d2fad99b5d2f88844892a0ec284	nicolelisa
Changed enpoint for ajax request to point to TextBasedReviewUIView url	20b38c6b129876ce9714e3a13672182c88fa8866	nicolelisa
Renamed TextBasedReviewUIView to TextBasedReviewUITextView	fad657c963f5bdf9b98f38eaa802fa033591c203	nicolelisa
Added in Review Request #10731 changes completed by Adil	b2bef6b73d110507856bf81618e48a846ccc79ec	nicolelisa
Add dummy features for the Ajax functionality	8db350412c01e143b1d21654493f7667b80ea218	nicolelisa

Diff:

Revision 12 (+2092 -764)

Show changes

	reviewboard/deprecation.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/markdownui.py
	11 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/markdownui.py (Diff revision 12)
An issue was opened. Show all issues
```
F401 'django.http.HttpResponse' imported but unused
```
reviewboard/reviews/ui/markdownui.py (Diff revision 12)
An issue was opened. Show all issues
```
F401 'django.utils.safestring.mark_safe' imported but unused
```

reviewboard/reviews/ui/markdownui.py (Diff revision 12)

An issue was opened. Show all issues

F401 'djblets.util.compat.django.template.loader.render_to_string' imported but unused

Fix it!

reviewboard/admin/urls.py (Diff revision 12)

An issue was opened. Show all issues

This should be removed, I've removed it from my AJAX function review request now as well

reviewboard/admin/urls.py (Diff revision 12)

An issue was opened. Show all issues

This should be removed, I've removed it from my AJAX function review request now as well

reviewboard/admin/urls.py (Diff revision 12)

An issue was opened. Show all issues

This should be removed, I've removed it from my AJAX function review request now as well

reviewboard/admin/urls.py (Diff revision 12)

An issue was opened. Show all issues

This should be removed, I've removed it from my AJAX function review request now as well

reviewboard/reviews/ui/markdownui.py (Diff revision 12)

An issue was opened. Show all issues

All changes to this file should be reverted since they were just for testing purposes

reviewboard/reviews/ui/text.py (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/reviews/ui/text.py (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```

reviewboard/reviews/ui/text.py (Diff revision 12)

An issue was opened. Show all issues

This isn't too important but technically this should be an HTTP 400 error. 404 indicates the resource was not found, while 400 indicates that the client sent a bad request (in this case, an invalid render_type value counts as a bad request)

reviewboard/reviews/ui/text.py (Diff revision 12)

An issue was opened. Show all issues

This will need to be slightly modified to handle diff chunks, since those aren't stored using context['rendered_lines'] or context['text_lines']

reviewboard/reviews/ui/text.py (Diff revision 12)

An issue was opened. Show all issues

In my XML review request I had to set context['lines'] to the result of the generate_render() function to bypass the caching that occurs in get_rendered_lines(), I think you'll have to do that here as well

reviewboard/reviews/ui/text.py (Diff revision 12)
An issue was opened. Show all issues
```
This should be context['lines'] = context['text_lines']
```
reviewboard/reviews/ui/text.py (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/reviews/ui/text.py (Diff revision 12)
An issue was opened. Show all issues
```
This should either be implemented and used in some way or removed
```

reviewboard/reviews/ui/text.py (Diff revision 12)

An issue was opened. Show all issues

Maybe a different name for this key would be more suitable? It may not be that intuitive to others what 'reviewUIId' actually means. 'reviewUiType' perhaps?

reviewboard/reviews/views_mixins.py (Diff revision 12)
An issue was opened. Show all issues
```
This comment should be removed
```
reviewboard/reviews/views_mixins.py (Diff revision 12)
An issue was opened. Show all issues
```
This comment should be removed
```

reviewboard/static/rb/js/views/abstractReviewableView.es6.js (Diff revision 12)

An issue was opened. Show all issues

This isn't important for this review request but in my AJAX function review request, there was a check for whether a comment should be rendered or not here. Since that will likely be useful for your JSON review UI if you rebase on top of this review request, you should remember to add that here in your JSON code.

reviewboard/static/rb/js/views/markdownReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
The docstring should be modified to include the 'renderType' parameter since you are using it
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/templates/reviews/ui/markdown.html (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```
reviewboard/templates/reviews/ui/text.html (Diff revision 12)
An issue was opened. Show all issues
```
This test code should be removed
```