flake8
-
reviewboard/admin/urls.py (Diff revision 1) Show all issues
Review Request #10749 — Created Oct. 9, 2019 and updated
Information | |
---|---|
amalik2 | |
Review Board | |
master | |
10745, 10731 | |
10713 | |
Reviewers | |
reviewboard, students | |
Individual review UIs that have dynamic render options can call this function,
and optionally pass in extra query parameters to send to the endpoint.More details can be found here
- Ran JavaScript unit tests.
- Tested manually to make sure that the element to update actually gets
updated by using a mock endpoint.- Tested manually to make sure comments are correctly reattached after
a request is finished.
Summary | Author |
---|---|
amalik2 |
Description | From | Last Updated |
---|---|---|
This also depends on the endpoint that will serve up the contents of the tables, so for now there's some … |
|
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 24 ['$el'] is better written in dot notation. |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E265 block comment should start with '# ' |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E265 block comment should start with '# ' |
![]() |
|
New CSS should follow this guide |
|
|
You can use regular function statements here. |
|
|
Leftover testing code? |
|
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E265 block comment should start with '# ' |
![]() |
|
Col: 6 Unnecessary semicolon. |
![]() |
|
Col: 6 Unnecessary semicolon. |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E265 block comment should start with '# ' |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E265 block comment should start with '# ' |
![]() |
Commits: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+444 -4) |
reviewboard/static/rb/js/views/textCommentRowSelector.es6.js (Diff revision 2) |
---|
Col: 24 ['$el'] is better written in dot notation.
Summary: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 3 (+575 -27) |
Commits: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+587 -31) |
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4) |
---|
You can use regular
function
statements here.
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 4) |
---|
Leftover testing code?
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+600 -38) |
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5) |
---|
Col: 6 Unnecessary semicolon.
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5) |
---|
Col: 6 Unnecessary semicolon.
Commits: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+566 -4) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 7 (+584 -4) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+364 -4) |