Summary:

Added function to reload render options with AJAX.

Review Request #10749 — Created Oct. 9, 2019 and updated Dec. 2, 2019, 11:01 p.m.

Information
Owner:	amalik2
Repository:	Review Board
Branch:	master
Bugs:
Depends On:	10745, 10731
Blocks:	10713
Reviewers
Groups:	reviewboard, students
People:

Description

Individual review UIs that have dynamic render options can call this function,
and optionally pass in extra query parameters to send to the endpoint.

More details can be found here

Testing Done


Ran JavaScript unit tests.
Tested manually to make sure that the element to update actually gets

updated by using a mock endpoint.
Tested manually to make sure comments are correctly reattached after

a request is finished.

Commits

Summary	Author
Added function to reload render options with AJAX.	amalik2

Screenshots

Issues

Description	From	Last Updated
This also depends on the endpoint that will serve up the contents of the tables, so for now there's some …	amalik2	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 9, 2019, 10:27 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 9, 2019, 10:27 p.m.
Col: 24 ['$el'] is better written in dot notation.	reviewbot	Oct. 13, 2019, 9:40 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 2, 2019, 11 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 2, 2019, 11:01 p.m.
New CSS should follow this guide	brennie	Oct. 20, 2019, 1:51 p.m.
You can use regular function statements here.	brennie	Oct. 20, 2019, 1:51 p.m.
Leftover testing code?	brennie	Oct. 20, 2019, 11:30 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 2, 2019, 11:01 p.m.
Col: 6 Unnecessary semicolon.	reviewbot	Oct. 20, 2019, 1:54 p.m.
Col: 6 Unnecessary semicolon.	reviewbot	Oct. 20, 2019, 1:54 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 2, 2019, 11:01 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 2, 2019, 11:01 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
-	contentReloaded TODO message	amalik2
+	Added function to reload render options with AJAX.	amalik2
+	contentReloaded TODO message	amalik2
+	started on reloading comments after reloading data	amalik2

Diff:

Revision 2 (+444 -4)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/admin/urls.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```

JSHint

reviewboard/static/rb/js/views/textCommentRowSelector.es6.js (Diff revision 2)
Show all issues
```
Col: 24
 ['$el'] is better written in dot notation.
```

Depends On:

+	10745 - Fixed RB.apiCall overwriting completed callback function.

Summary:

-	WIP: Added function to reload render options with AJAX.
+	Added function to reload render options with AJAX.

Description:

~		Still need to reload comments when a table gets updated
	~	Individual review UIs that have dynamic render options can call this function,
	+	and optionally pass in extra query parameters to send to the endpoint.
	+
	+	More details can be found here

Testing Done:

		Ran JavaScript unit tests.
		Tested manually to make sure that the element to update actually gets updated by using a mock endpoint.
	+	Tested manually to make sure comments are correctly reattached after a request is finished.

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
-	contentReloaded TODO message	amalik2
-	started on reloading comments after reloading data	amalik2
+	Added function to reload render options with AJAX.	amalik2
+	contentReloaded TODO message	amalik2
+	started on reloading comments after reloading data	amalik2
+	fixed refreshing comments after table reloads	amalik2
+	refactored refresh	amalik2

Diff:

Revision 3 (+575 -27)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 3)
Show all issues
```
E265 block comment should start with '# '
```

Show all issues

This also depends on the endpoint that will serve up the contents of the tables, so for now there's some code here for testing purposes that I'll remove later

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
-	contentReloaded TODO message	amalik2
-	started on reloading comments after reloading data	amalik2
-	fixed refreshing comments after table reloads	amalik2
-	refactored refresh	amalik2
+	Added function to reload render options with AJAX.	amalik2
+	contentReloaded TODO message	amalik2
+	started on reloading comments after reloading data	amalik2
+	fixed refreshing comments after table reloads	amalik2
+	refactored refresh	amalik2
+	fixed div not being disabled	amalik2

Depends On:

+	10731 - Added render options block to text review template.

Diff:

Revision 4 (+587 -31)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 4)
Show all issues
```
E265 block comment should start with '# '
```

Fix it!

reviewboard/static/rb/css/common.less (Diff revision 4)
Show all issues
```
New CSS should follow this guide
```
1. amalik2 Oct. 20, 2019, 1:51 p.m.
  I think this is resolved now

reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4)

Show all issues

You can use regular function statements here.

reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 4)
Show all issues
```
Leftover testing code?
```
1. amalik2 Oct. 20, 2019, 1:51 p.m.
  Yes, I'm not sure what endpoint I'm supposed to hit right now

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
-	contentReloaded TODO message	amalik2
-	started on reloading comments after reloading data	amalik2
-	fixed refreshing comments after table reloads	amalik2
-	refactored refresh	amalik2
-	fixed div not being disabled	amalik2
+	Added function to reload render options with AJAX.	amalik2
+	contentReloaded TODO message	amalik2
+	started on reloading comments after reloading data	amalik2
+	fixed refreshing comments after table reloads	amalik2
+	refactored refresh	amalik2
+	fixed div not being disabled	amalik2
+	addressed comments on review request	amalik2

Diff:

Revision 5 (+600 -38)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/admin/urls.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 5)
Show all issues
```
E265 block comment should start with '# '
```

JSHint

reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5)
Show all issues
```
Col: 6
 Unnecessary semicolon.
```
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5)
Show all issues
```
Col: 6
 Unnecessary semicolon.
```

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
-	contentReloaded TODO message	amalik2
-	started on reloading comments after reloading data	amalik2
-	fixed refreshing comments after table reloads	amalik2
-	refactored refresh	amalik2
-	fixed div not being disabled	amalik2
-	addressed comments on review request	amalik2
+	Added function to reload render options with AJAX.	amalik2

Diff:

Revision 6 (+566 -4)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 6)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 6)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 6)
Show all issues
```
E265 block comment should start with '# '
```

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
+	Added function to reload render options with AJAX.	amalik2

Diff:

Revision 7 (+584 -4)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/urls.py (Diff revision 7)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 7)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/urls.py (Diff revision 7)
Show all issues
```
E265 block comment should start with '# '
```

Commits:

	Summary	Author
-	Added function to reload render options with AJAX.	amalik2
+	Added function to reload render options with AJAX.	amalik2

Diff:

Revision 8 (+364 -4)

Show changes

	reviewboard/admin/urls.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/views/abstractReviewableView.es6.js
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.