Added difference viewer for XML files.

Review Request #10713 — Created Sept. 11, 2019 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

There is now a syntax highlighted rendered view for XML files, where each node
in the XML document will be consistently indented so that it is easy to see
the actual contents of the document, even if the document is minified or
improperly formatted.

Unicode characters will be properly displayed in the render view as well.

There is also support for comparing different XML files with either the
render view or normal text view.

1) Ran unit tests on Python 2.7 and 3.6.
2) Tested manually on Python 2.7 and 3.6 outside of the diff viewer.
3) Tested manually on Python 2.7 and 3.6 inside of the diff viewer.
4) Tested manually on Python 2.7 and 3.6 with a document with UTF-8 encoding
and characters.
5) Tested manually on Python 2.7 and 3.6 with an invalid XML document that
leads to an error while parsing.

Diff Revision 13

This is not the most recent revision of the diff. The latest diff is revision 20. See what's changed.

orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20

Commits

First Last Summary ID Author
Added difference viewer for XML files.
1a4d4b1e210c4dcfe45a1e5b7168c8be4e84f84f amalik2
fixed encoding issue
111909238d443efa14c2a7ee1a380d499c5fd4f0 amalik2
Removed render options from text template
392012c86554ccff1bf543f0ae51e54435354ad5 amalik2
removed hack for extra whitespace fix
97bceaabcfbf910c4b8f89afd033740cf418a0fa amalik2
reviewboard/dependencies.py
reviewboard/staticbundles.py
reviewboard/reviews/tests/test_xml_review_ui.py
reviewboard/reviews/ui/__init__.py
reviewboard/reviews/ui/xmlui.py
reviewboard/static/rb/css/pages/text-review-ui.less
reviewboard/static/rb/js/models/xmlBasedReviewableModel.es6.js
reviewboard/static/rb/js/views/xmlRenderOptionsView.es6.js
reviewboard/static/rb/js/views/xmlReviewableView.es6.js
Loading...