Summary

Added difference viewer for XML files.

Review Request #10713 — Created Sept. 11, 2019 and updated Dec. 2, 2019, 10:55 p.m.

Information

Owner

amalik2

Repository

Review Board

Branch

master

Bugs

Depends On

10758, 10749, ~~10709~~

Reviewers

Groups

reviewboard, students

People

Description

There is now a syntax highlighted rendered view for XML files, where each node
in the XML document will be consistently indented so that it is easy to see
the actual contents of the document, even if the document is minified or
improperly formatted.

Unicode characters will be properly displayed in the render view as well.

There is also support for comparing different XML files with either the
render view or normal text view.

Testing Done

1) Ran unit tests on Python 2.7 and 3.6.
2) Tested manually on Python 2.7 and 3.6 outside of the diff viewer.
3) Tested manually on Python 2.7 and 3.6 inside of the diff viewer.
4) Tested manually on Python 2.7 and 3.6 with a document with UTF-8 encoding
and characters.
5) Tested manually on Python 2.7 and 3.6 with an invalid XML document that
leads to an error while parsing.

Commits

Summary	ID	Author
Added difference viewer for XML files.	6ecd8fc45dcbe2cfb94b5f3bac5a24cd7c2ad138	amalik2

Files

Issues

Description	From	Last Updated
Is this a real CDATA section, e.g. <![CDATA[[< WORKS !!! >]]> If so, it really should render like it is …	brennie	Sept. 15, 2019, 11:50 p.m.
F401 'lxml.etree' imported but unused	reviewbot	Sept. 11, 2019, 8:04 p.m.
F401 'django.utils.encoding.force_text' imported but unused	reviewbot	Sept. 11, 2019, 8:04 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:05 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:19 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 11, 2019, 8:06 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:06 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:06 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Sept. 11, 2019, 8:06 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Sept. 11, 2019, 8:06 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Sept. 11, 2019, 8:06 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Sept. 11, 2019, 8:06 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:06 p.m.
E271 multiple spaces after keyword	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E231 missing whitespace after ','	reviewbot	Sept. 11, 2019, 8:20 p.m.
F811 redefinition of unused 'test_get_siblings_after_root_no_siblings' from line 252	reviewbot	Sept. 11, 2019, 8:20 p.m.
E231 missing whitespace after ','	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E501 line too long (180 > 79 characters)	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E501 line too long (180 > 79 characters)	reviewbot	Sept. 11, 2019, 8:20 p.m.
F401 'djblets.markdown.iter_markdown_lines' imported but unused	reviewbot	Sept. 11, 2019, 8:20 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 11, 2019, 8:20 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:20 p.m.
E201 whitespace after '{'	reviewbot	Sept. 11, 2019, 8:20 p.m.
E202 whitespace before '}'	reviewbot	Sept. 11, 2019, 8:20 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 11, 2019, 8:20 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Sept. 11, 2019, 8:25 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Sept. 11, 2019, 8:25 p.m.
F821 undefined name '_'	reviewbot	Sept. 11, 2019, 8:25 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:25 p.m.
E202 whitespace before '}'	reviewbot	Sept. 11, 2019, 8:25 p.m.
E202 whitespace before '}'	reviewbot	Sept. 11, 2019, 8:25 p.m.
E202 whitespace before '}'	reviewbot	Sept. 11, 2019, 8:25 p.m.
E202 whitespace before '}'	reviewbot	Sept. 11, 2019, 8:25 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:25 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:25 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:25 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 11, 2019, 8:25 p.m.
E201 whitespace after '('	reviewbot	Sept. 15, 2019, 11:55 p.m.
E201 whitespace after '('	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:55 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 15, 2019, 11:56 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Sept. 15, 2019, 11:56 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 15, 2019, 11:56 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 15, 2019, 11:56 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Sept. 15, 2019, 11:56 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Sept. 15, 2019, 11:56 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
W291 trailing whitespace	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:59 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 15, 2019, 11:59 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 15, 2019, 11:59 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:59 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:58 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 15, 2019, 11:58 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 16, 2019, 12:01 a.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 16, 2019, 12:01 a.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 16, 2019, 12:01 a.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 16, 2019, 12:01 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 16, 2019, 12:03 a.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 16, 2019, 12:03 a.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 16, 2019, 12:03 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 16, 2019, 12:03 a.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 16, 2019, 12:07 a.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 16, 2019, 12:07 a.m.
E501 line too long (87 > 79 characters)	reviewbot	Sept. 16, 2019, 9:10 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Sept. 16, 2019, 9:10 p.m.
F821 undefined name 'contents'	reviewbot	Sept. 22, 2019, 1:14 p.m.
F821 undefined name 'contents'	reviewbot	Sept. 22, 2019, 1:14 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Sept. 22, 2019, 1:14 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Sept. 23, 2019, 10:08 a.m.
W293 blank line contains whitespace	reviewbot	Sept. 23, 2019, 10:08 a.m.
F811 redefinition of unused 'RemovedInReviewBoard60Warning' from line 42	reviewbot	Dec. 2, 2019, 10:54 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 99 failures.
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'lxml.etree' imported but unused
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.utils.encoding.force_text' imported but unused
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/tests/test_xml_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary	ID	Author
	Added difference viewer for XML files.	f42d889be2fe19272010b1c62a974efa95186c77	amalik2
	Added difference viewer for XML files.	4b00ace6633843b71d42d9d9ed350e01c0753d0f	amalik2

Diff:

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/reviews/xml_utils.py
	reviewboard/reviews/tests/test_xml_utils.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/xmlui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/xmlReviewableView.es6.js

~		1) Ran unit tests on Python2.7
~		2) Ran unit tests on Python3.6
~		3) Tested manually on Python 2.7 and 3.6 outside of the diff viewer
~		4) Tested manually on Python 2.7 and 3.6 inside of the diff viewer
~		5) Tested manually on Python 2.7 and 3.6 with a document with UTF-8 encoding
~		and characters
	~	1) Ran unit tests on Python 2.7 and 3.6.
	~	2) Tested manually on Python 2.7 and 3.6 outside of the diff viewer.
	~	3) Tested manually on Python 2.7 and 3.6 inside of the diff viewer.
	~	4) Tested manually on Python 2.7 and 3.6 with a document with UTF-8 encoding
	~	and characters.
	~	5) Tested manually on Python 2.7 and 3.6 with an invalid XML document that
	+	leads to an error while parsing.

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_xml_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/text.py
	reviewboard/reviews/ui/xmlui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/xmlBasedReviewableModel.es6.js
	3 more

Summary	ID	Author
Added difference viewer for XML files.	1a4d4b1e210c4dcfe45a1e5b7168c8be4e84f84f	amalik2
fixed encoding issue	111909238d443efa14c2a7ee1a380d499c5fd4f0	amalik2
Added difference viewer for XML files.	1a4d4b1e210c4dcfe45a1e5b7168c8be4e84f84f	amalik2
fixed encoding issue	111909238d443efa14c2a7ee1a380d499c5fd4f0	amalik2
Removed render options from text template	392012c86554ccff1bf543f0ae51e54435354ad5	amalik2

Summary	ID	Author
Added difference viewer for XML files.	89eccc9d0a3de6761975239ba18f3f95f2244493	amalik2
Added difference viewer for XML files.	89eccc9d0a3de6761975239ba18f3f95f2244493	amalik2
fixes	00fdab702318caa76b75c51f7e23b2f4c689ca20	amalik2

	Summary	ID	Author
	Added difference viewer for XML files.	8b6e284bd306f1cd0e093049e23a45ab50f8cd81	amalik2
	Added difference viewer for XML files.	20db34b77f461d5bc9cc598266854bbdc77aba77	amalik2

	reviewboard/dependencies.py
	reviewboard/deprecation.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/views_mixins.py
	reviewboard/reviews/tests/test_file_attachment_review_ui.py
	18 more

	Summary	ID	Author
	Added difference viewer for XML files.	9acc7eccb53a671bcf91e99532e25bd7fc6af1d2	amalik2
	Added difference viewer for XML files.	6ecd8fc45dcbe2cfb94b5f3bac5a24cd7c2ad138	amalik2

Added difference viewer for XML files.

Information

Reviewers

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)