Make draft colors consistent.

Review Request #10466 — Created March 24, 2019 and submitted — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

We had a bunch of different definitions of the "draft" color, several of
which were actually closer to the "ship-it" color than the draft banner
color. This change makes it all consistent throughout, creating a single
@draft-color definition which is based on the new color scheme. This
is then used everywhere that we want to indicate that there's something
in a draft state.

Some of this looked weird at first, because brains hate change. As I've
spent a little more time with it I've quickly gotten used to it and I
like it better.

Looked throughout the UI at all the different draft-related items.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Make draft colors consistent.
We had a bunch of different definitions of the "draft" color, several of which were actually closer to the "ship-it" color than the draft banner color. This change makes it all consistent throughout, creating a single `@draft-color` definition which is based on the new color scheme. This is then used everywhere that we want to indicate that there's something in a draft state. Some of this looked weird at first, because brains hate change. As I've spent a little more time with it I've quickly gotten used to it and I like it better. Testing Done: Looked throughout the UI at all the different draft-related items.
a4d3d043df2ec78081dfe032ea31d3bc73acd20b David Trowbridge
reviewboard/static/rb/css/defs.less
reviewboard/static/rb/css/pages/reviews.less
reviewboard/static/rb/css/ui/banners.less
reviewboard/static/rb/css/ui/colors.less
reviewboard/static/rb/images/icons.png
reviewboard/static/rb/images/icons.svg
reviewboard/static/rb/images/icons@2x.png
Loading...