Summary

Make link colors consistent.

Review Request #10467 — Created March 27, 2019 and submitted May 17, 2019, 11:50 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~10466~~

Reviewers

Groups

reviewboard

People

Description

We had a bunch of different places where we had link colors of various
shades of blue. This standardizes them all into a single @link-color
definition, which is the same as @blue-20. While doing this, I decided
that the definition for that particular color (drawn from a mockup we
have) wasn't really blue enough to provide real contrast against white
and grey backgrounds, so I pushed the saturation a little bit.

Testing Done

Flipped through the UI and looked for all the links I could find.

Commits

Summary	ID
Make link colors consistent. We had a bunch of different places where we had link colors of various shades of blue. This standardizes them all into a single `@link-color` definition, which is the same as `@blue-20`. While doing this, I decided that the definition for that particular color (drawn from a mockup we have) wasn't really blue enough to provide real contrast against white and grey backgrounds, so I pushed the saturation a little bit. Testing Done: Flipped through the UI and looked for all the links I could find.	d828b66b688db9fc9b3b95f94b1d0ced9de33ffb

Summary

Make link colors consistent.

We had a bunch of different places where we had link colors of various shades of blue. This standardizes them all into a single `@link-color` definition, which is the same as `@blue-20`. While doing this, I decided that the definition for that particular color (drawn from a mockup we have) wasn't really blue enough to provide real contrast against white and grey backgrounds, so I pushed the saturation a little bit. Testing Done: Flipped through the UI and looked for all the links I could find.

d828b66b688db9fc9b3b95f94b1d0ced9de33ffb

Files

Issues

Description	From	Last Updated
Actually, is this the same blue in the latest screenshot of the draft color change? If so, it's not contrasting …	chipx86	April 30, 2019, 11:43 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Actually, is this the same blue in the latest screenshot of the draft color change? If so, it's not contrasting well with the review request page banner.

Change Summary:

Bump up saturation some more.

Commits:

	Summary	ID
	Make link colors consistent. We had a bunch of different places where we had link colors of various shades of blue. This standardizes them all into a single `@link-color` definition, which is the same as `@blue-20`. While doing this, I decided that the definition for that particular color (drawn from a mockup we have) wasn't really blue enough to provide real contrast against white and grey backgrounds, so I pushed the saturation a little bit. Testing Done: Flipped through the UI and looked for all the links I could find.	ad26ec09ad92aa024a799ce90c9c66e431926d79
	Make link colors consistent. We had a bunch of different places where we had link colors of various shades of blue. This standardizes them all into a single `@link-color` definition, which is the same as `@blue-20`. While doing this, I decided that the definition for that particular color (drawn from a mockup we have) wasn't really blue enough to provide real contrast against white and grey backgrounds, so I pushed the saturation a little bit. Testing Done: Flipped through the UI and looked for all the links I could find.	d828b66b688db9fc9b3b95f94b1d0ced9de33ffb

Diff:

Revision 2 (+30 -38)

Show changes

	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/static/rb/css/pages/admin-dashboard.less
	reviewboard/static/rb/css/pages/base.less
	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/css/ui/colors.less
	reviewboard/static/rb/css/ui/datagrids.less

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (3b4b450)