JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1) Show all issues -
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1) Col: 30 Forgotten 'debugger' statement?
Review Request #10128 — Created Aug. 25, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-4.0.x | |
|
|
10132 | |
d57abd3... | |
Reviewers | |
reviewboard | |
When doing an interdiff, it is possible that there could be two commits
in theRB.DiffCommitCollection
that have the samecommitId
property.
However, they may have different properties (however unlikely), so we
now serialize commits with their primary keys and use them for lookup in
history entries instead of the commit ID. This was especially prevalent
in test cases where the commit IDs were not actually representative
(i.e., a hash) of the content of the commit.
Description | From | Last Updated |
---|---|---|
Col: 30 Expected '{' and instead saw 'debugger'. |
![]() |
|
Col: 30 Forgotten 'debugger' statement? |
![]() |
|
Col: 30 Expected '{' and instead saw 'debugger'. |
![]() |
|
Col: 30 Forgotten 'debugger' statement? |
![]() |
|
Unwanted "for" in the summary. |
|
|
Can you put this in alphabetical order? |
|
|
Too many blank lines. |
|
|
This will easily fit on one line. It'll fit on the previous if you do: diffset = review_request_details.get_latest_diffset() editor_data['commits'] = … |
|
|
Should be in alphabetical order. |
|
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1) |
---|
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1) |
---|
Col: 30 Forgotten 'debugger' statement?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+60 -36) |
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 2) |
---|
Col: 30 Expected '{' and instead saw 'debugger'.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 2) |
---|
Col: 30 Forgotten 'debugger' statement?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+58 -36) |
reviewboard/diffviewer/models/diffcommit.py (Diff revision 3) |
---|
Can you put this in alphabetical order?
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 3) |
---|
This will easily fit on one line.
It'll fit on the previous if you do:
diffset = review_request_details.get_latest_diffset() editor_data['commits'] = [ commit.serialize() for commit in diffset.commits.all() ]
reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js (Diff revision 3) |
---|
Should be in alphabetical order.
Addressed feedback.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+58 -37) |
Address feedback, update js tests.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+64 -37) |
Unit test updates from /r/10125/ and /r/10126/
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+75 -42) |