JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1) Show all issues
Review Request #10132 — Created Aug. 30, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-4.0.x | |
|
|
10136 | |
3391784... | |
Reviewers | |
reviewboard | |
The
RB.DiffCommitListView
can now optionally display controls for
selecting between base and tip commits to control what will be displayed
in the diffviewer. The actual logic for changing the diffs is not yet
implemented -- just the control itself.
Ran JS tests.
Description | From | Last Updated |
---|---|---|
Screenshot? |
|
|
Col: 36 Missing semicolon. |
![]() |
|
Col: 55 Missing semicolon. |
![]() |
|
Col: 36 Missing semicolon. |
![]() |
|
Col: 55 Missing semicolon. |
![]() |
|
Col: 36 Missing semicolon. |
![]() |
|
Col: 55 Missing semicolon. |
![]() |
|
Col: 36 Missing semicolon. |
![]() |
|
Alphabetical order. |
|
|
If there is no parent in the collection. |
|
|
Indentation is incorrect for the comment. |
|
|
Alphabetical order. |
|
|
Alphabetical order. |
|
|
Alphabetical order. |
|
|
"Option Args" |
|
|
Indentation is wrong. This would fit on one line though. |
|
|
Parents around the ternary. The ? and : should also align with tipCommitID. |
|
|
You can start the first parameter on the listenTo line. |
|
|
Missing docs. |
|
|
This looks like leftover debugging? Maybe just put a TODO here, or leave out the function until it's implemented. |
|
jshint
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+466 -46) |
Rebase.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+465 -42) |
Use PKs over commit IDs
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 4) |
---|
Col: 55 Missing semicolon.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 4) |
---|
Col: 36 Missing semicolon.
CommitId -> CommitID
Commit: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+501 -42)
|
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 5) |
---|
Col: 55 Missing semicolon.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 5) |
---|
Col: 36 Missing semicolon.
CommitId -> CommitID
Commit: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+502 -42)
|
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 6) |
---|
Col: 55 Missing semicolon.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 6) |
---|
Col: 36 Missing semicolon.
jshint
Commit: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 7 (+502 -42)
|
reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js (Diff revision 7) |
---|
Alphabetical order.
reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js (Diff revision 7) |
---|
Alphabetical order.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7) |
---|
Alphabetical order.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7) |
---|
Indentation is wrong.
This would fit on one line though.
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7) |
---|
Parents around the ternary.
The
?
and:
should also align withtipCommitID
.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 7) |
---|
You can start the first parameter on the
listenTo
line.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 7) |
---|
This looks like leftover debugging?
Maybe just put a TODO here, or leave out the function until it's implemented.
Addressed feedback.
Commit: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+488 -40)
|
Addressed feedback.
Commit: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 9 (+494 -40)
|