Add controls to select base and tip commits in the RB.DiffCommitListView

Review Request #10132 — Created Aug. 30, 2018 and submitted

brennie
Review Board
release-4.0.x
10128
10136
3391784...
reviewboard

The RB.DiffCommitListView can now optionally display controls for
selecting between base and tip commits to control what will be displayed
in the diffviewer. The actual logic for changing the diffs is not yet
implemented -- just the control itself.

Ran JS tests.

Loading file attachments...

Description From Last Updated

Screenshot?

daviddavid

Col: 36 Missing semicolon.

reviewbotreviewbot

Col: 55 Missing semicolon.

reviewbotreviewbot

Col: 36 Missing semicolon.

reviewbotreviewbot

Col: 55 Missing semicolon.

reviewbotreviewbot

Col: 36 Missing semicolon.

reviewbotreviewbot

Col: 55 Missing semicolon.

reviewbotreviewbot

Col: 36 Missing semicolon.

reviewbotreviewbot

Alphabetical order.

chipx86chipx86

If there is no parent in the collection.

chipx86chipx86

Indentation is incorrect for the comment.

chipx86chipx86

Alphabetical order.

chipx86chipx86

Alphabetical order.

chipx86chipx86

Alphabetical order.

chipx86chipx86

"Option Args"

chipx86chipx86

Indentation is wrong. This would fit on one line though.

chipx86chipx86

Parents around the ternary. The ? and : should also align with tipCommitID.

chipx86chipx86

You can start the first parameter on the listenTo line.

chipx86chipx86

Missing docs.

chipx86chipx86

This looks like leftover debugging? Maybe just put a TODO here, or leave out the function until it's implemented.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

brennie
brennie
brennie
Review request changed
brennie
Review request changed
brennie
Review request changed
brennie
chipx86
  1. 
      
  2. reviewboard/diffviewer/models/diffcommit.py (Diff revision 7)
     
     
     
     

    Alphabetical order.

  3. If there is no parent in the collection.

  4. Indentation is incorrect for the comment.

  5. Alphabetical order.

  6. Alphabetical order.

  7. Indentation is wrong.

    This would fit on one line though.

  8. Parents around the ternary.

    The ? and : should also align with tipCommitID.

  9. You can start the first parameter on the listenTo line.

  10. This looks like leftover debugging?

    Maybe just put a TODO here, or leave out the function until it's implemented.

  11. 
      
brennie
david
  1. 
      
  2. Screenshot?

  3. 
      
brennie
brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (d0a58dd)
Loading...