Use the RB.DiffCommitListView for change descriptions

Review Request #10127 — Created Aug. 24, 2018 and updated

brennie
Review Board
release-4.0.x
10126
10128
624eeaa...
reviewboard

The commit lists in change descriptions now use the
RB.DiffCommitListView so that their contents can be expanded/collapsed
as needed.

  • Ran JS tests.
  • Ran unit tests.
Loading file attachments...

  • 0
  • 0
  • 14
  • 2
  • 16
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
brennie
Review request changed
brennie
chipx86
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 4)
     
     
     
     

    You can assign commits directly instead of having an otherwise unused variable.

    1. commits is used. It is used by _get_common_context.

    2. Oops, misread this.

  3. reviewboard/reviews/builtin_fields.py (Diff revision 4)
     
     
     

    Should use keyword arguments for future compatibility.

  4. reviewboard/reviews/detail.py (Diff revision 4)
     
     

    Missing :js:class:.

  5. reviewboard/reviews/detail.py (Diff revision 4)
     
     
     
     
     
     

    Can this use the new serialize()?

    1. This patch actually comes before /r/10128/ in my tree. Missed the depends-on.

    2. Oops no I didn't. /r/10128 correctly depends on this change, which fixes this.

  6. Alphabetical order.

  7. There should be two blank lines on both sides.

  8. No spaces immediately within {..}

  9. Can you update this to use the expanded form?

  10. Alphabetical order.

  11. 
      
brennie
Review request changed
brennie
chipx86
  1. 
      
  2. reviewboard/reviews/detail.py (Diff revision 6)
     
     
     

    Rather than .update(), just set model_data['commits'] directly, since it's the only thing going in.

  3. Typo: "attribtues" -> "attributes"

  4. 
      
brennie
Review request changed
Loading...