flake8
failed.
JSHint
passed.
Use the RB.DiffCommitListView for change descriptions
Review Request #10127 — Created Aug. 24, 2018 and submitted
The commit lists in change descriptions now use the
RB.DiffCommitListViewso that their contents can be expanded/collapsed
as needed.
- Ran JS tests.
- Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
F401 'reviewboard.diffviewer.commit_utils.diff_histories' imported but unused |
 reviewbot
|
|
|
F811 redefinition of unused 'test_render_change_entry_html_expand' from line 364 |
reviewbot
|
|
|
You can assign commits directly instead of having an otherwise unused variable. |
 chipx86
|
|
|
Should use keyword arguments for future compatibility. |
chipx86
|
|
|
Missing :js:class:. |
chipx86
|
|
|
Can this use the new serialize()? |
chipx86
|
|
|
Alphabetical order. |
chipx86
|
|
|
There should be two blank lines on both sides. |
chipx86
|
|
|
No spaces immediately within {..} |
chipx86
|
|
|
Can you update this to use the expanded form? |
chipx86
|
|
|
Alphabetical order. |
chipx86
|
|
|
Should use the expanded form. |
chipx86
|
|
|
F821 undefined name 'commits' |
reviewbot
|
|
|
Rather than .update(), just set model_data['commits'] directly, since it's the only thing going in. |
chipx86
|
|
|
Typo: "attribtues" -> "attributes" |
chipx86
|
|
|
Same typo. |
chipx86
|
|
|
Super nit, but can we swap these so it's alphabetical? |
 david
|
|
|
Doc comment? |
david
|
|
|
I don't understand why you changed this to be a function. It seems like we could leave it as-is and … |
david
|
|
|
This needs a doc comment that explains why it's a function. |
david
|
|
|
This needs to be documented in ModelAttributes above. |
chipx86
|
|
|
Missing trailing comma. |
chipx86
|
|
|
As in the other change, I'd prefer if we only added the colspan if needed. |
chipx86
|
|
|
Let's set the list of commits directly into the context. |
chipx86
|
- Change Summary:
-
Unit test fixes.
- Commit:
-
1f4e5bef5230d2c4376020009caa6dd049b5ce951316de68d4a31f2c88ea428d4514c191f49cab81
- Diff:
-
Revision 2 (+405 -81)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
1316de68d4a31f2c88ea428d4514c191f49cab81f44bcd955db2d4d9e3a8f0f7c202d6fe1ee688a8
- Diff:
-
Revision 3 (+505 -86)
- Change Summary:
-
Remove duplicate unit test?? git rerere is not without drawbacks...
- Commit:
-
f44bcd955db2d4d9e3a8f0f7c202d6fe1ee688a83f0c379112da3914ef9f5913814fa265e9c678ff
- Diff:
-
Revision 4 (+408 -86)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed feedback
- Commit:
-
3f0c379112da3914ef9f5913814fa265e9c678fff86b9c806dc0b83eeec3bbd3237fd7fd95893ad0
- Diff:
-
Revision 5 (+408 -82)
- Commit:
-
f86b9c806dc0b83eeec3bbd3237fd7fd95893ad0ea9063287bcce75761f974a3e4da2a41aa5c91e9
- Diff:
-
Revision 6 (+408 -81)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed feedback.
- Depends On:
-
- Commit:
ea9063287bcce75761f974a3e4da2a41aa5c91e9624eeaafecc537a068a4fb476e3163eef051d9c8- Diff:
Revision 7 (+407 -82)
Checks run (2 succeeded)
flake8 passed.JSHint passed.
- Change Summary:
-
Addressed feedback.
- Commit:
-
624eeaafecc537a068a4fb476e3163eef051d9c8b6f375a5b36078d33e9bf1b7c44f3c6e90497db3
- Diff:
-
Revision 8 (+413 -81)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
b6f375a5b36078d33e9bf1b7c44f3c6e90497db36b091059509e1c97f99b208aef6767b1ad482305
- Diff:
-
Revision 9 (+424 -81)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed feedback
- Commit:
-
6b091059509e1c97f99b208aef6767b1ad482305a0f7c502f62b2027557c9ad98ff79be1e7c802a3
- Diff:
-
Revision 10 (+429 -80)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.