Can you flesh out the description, describe how it's basic and what's missing?

E501 line too long (89 > 79 characters)

Col: 54 Expected a 'break' statement before 'default'.

Col: 13 Unexpected ')'.

Col: 13 Expected an identifier and instead saw ')'.

Col: 17 Expected ')' and instead saw ';'.

Col: 18 Missing semicolon.

Col: 21 It's not necessary to initialize 'rowClass' to 'undefined'.

Col: 17 Unexpected ')'.

Col: 17 Expected an identifier and instead saw ')'.

Col: 21 Expected ')' and instead saw ';'.

Col: 22 Missing semicolon.

Col: 13 Expected an identifier and instead saw ')'.

Col: 13 Unexpected ')'.

Col: 19 Missing semicolon.

Col: 18 Expected ')' and instead saw ';'.

E501 line too long (81 > 79 characters)

This seems unnecessary. Can't we just move that stuff into an __init__ in this class?

Needs to be the full type path.

Can you pass as keyword arguments, so this is self-describing? Same with all below.

Is it really worth having these? The construction is pretty simple.

Why aren't we just using __init__? This class is feeling unnecessarily complicated, and I don't have a sense as to …

Full type path, here and below.

No , or or in these.

Same here.

Can we say "Iterate through the diff between ...", so it's a bit more clear?

No blank line.

Doesn't seem like we'd need this namedtuple either. They kinda came out of nowhere, and I'm not sure they're appropriate …

This should be a list so that ordering is consistent in the query. That allows the database to cache the …

This can easily be one line.

These should be on the same line.

We have a trailing comma here, but this isn't a .es6.js file. Let's rename it.

Blank line between these.

Wrong number of spaces for indents.

Missing docstring.

You can use isEmpty().

It's always good to have a break, even in the last case.

These can start on the line with the call.

Typo: "cellection" -> "collection".

F401 'collections.namedtuple' imported but unused

F821 undefined name 'cls'

F821 undefined name 'cls'

F821 undefined name 'cls'

F401 'collections.namedtuple' imported but unused

E501 line too long (83 > 79 characters)

F401 'collections.namedtuple' imported but unused

F821 undefined name 'cls'

F821 undefined name 'cls'

F821 undefined name 'cls'

F401 'collections.namedtuple' imported but unused

E501 line too long (83 > 79 characters)

No trailing period.

No trailing period.

__init__ doesn't return.

Parameters should align.

No spaces within {..}

This doesn't look right.

Are i and j ever different? They start as 0, are both incremented at the same time, and never seem …

Can you put the full module path? Looks like it'd fit.

We always compare the result to the expectation. A failure here with these values backwards could be confusing to debug …

""" on the next line.

Alphabetical order.

Alphabetical order.

Alphabetical order.

Lookups would be faster if we just have a mapping defined (say, on RB.CommitHistoryDiffEntry, not the prototype) that mapped the …

Can you use the expanded form?

Same here.

F821 undefined name 'j'

Col: 2 Missing semicolon.

Docstring?

Docstring?

Babel turns this into a monster. We'll need to do it with a bunch of assignments instead.

We don't need the $() here, since append() can take an HTML string.

Same here with $()

And here.

It's best to also provide __ne__ for Python 2.x. On 3.x, we get this for free.

Typo: "attribtues" -> "attributes"

Kind of confused by the wording here around the double enumerate.

Can you wrap this at the "at"? It's slightly too long.

We can reduce the generated HTML and the test changes needed if we do: <th<% if (showExpandCollapse) { %>colspan="2"<% } …

These are a too long for the lines. How about building the response payload higher up, before the return maybe, …

Similar to above, let's only add the attribute if we have something other than "1" to set.

This isn't a boolean.