flake8
passed.
JSHint
passed.
Pass ReviewRequestPageDataMixin to fields that require it during render
Review Request #10083 — Created July 13, 2018 and discarded
We have several fields that use
ReviewRequestPageDataMixin, but they
only really use it for rendering change description entries. As such,
the review request page data is not passed to them during rendering. If
we wish to take advantage of all the queries that have been done, we
need to pass in this data.The review request page data is now passed into the template context of
the review detail view and is used by the
{% for_review_request_field %}template tag.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
F841 local variable 'review_request' is assigned to but never used |
 reviewbot
|
|
|
E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
F841 local variable 'review_request' is assigned to but never used |
reviewbot
|
|
|
E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
F821 undefined name 'data' |
reviewbot
|
|
|
E501 line too long (87 > 79 characters) |
reviewbot
|
Change Summary:
Fix unit test fails.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+52 -19) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/extensions/tests.py (Diff revision 2) -
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+53 -19) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/extensions/tests.py (Diff revision 3) F841 local variable 'review_request' is assigned to but never used
-
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+70 -20) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
-
reviewboard/reviews/views.py (Diff revision 4) Im not convinced this change is the correct way to do things since we have to introduce new queries to the diffviewer page.