Pass ReviewRequestPageDataMixin to fields that require it during render

Review Request #10083 — Created July 13, 2018 and discarded

brennie
Review Board
release-3.0.x
10082
reviewboard

We have several fields that use ReviewRequestPageDataMixin, but they
only really use it for rendering change description entries. As such,
the review request page data is not passed to them during rendering. If
we wish to take advantage of all the queries that have been done, we
need to pass in this data.

The review request page data is now passed into the template context of
the review detail view and is used by the
{% for_review_request_field %} template tag.

Ran unit tests.

  • 1
  • 0
  • 5
  • 0
  • 6
Description From Last Updated
E501 line too long (87 > 79 characters) reviewbot
brennie
Review request changed

Change Summary:

Fix unit test fails.

Commit:

-990055c1fb2fc56e4abdcec01d9f3692ce98d88f
+379b39aca9fad01987b793f138225b09f84c716b

Diff:

Revision 2 (+52 -19)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 4)
     
     
     

    Im not convinced this change is the correct way to do things since we have to introduce new queries to the diffviewer page.

  3. 
      
brennie
Review request changed

Status: Discarded

Loading...