flake8
failed.
JSHint
passed.
Review Request #10082 — Created July 13, 2018 and submitted
The
ReviewRequestPageDataMixin
was built on theBuiltinFieldMixin
.
However, this requires that the field being represented be available on
the review request draft asfield_id
or else the mixin will use the
review request instead. This is not ideal when the represented field is
derived state or not directly accessible as an attribute/property on the
review request draft, e.g., it is an attribute of the draft diff
instead.Now the two are more separate and fields that require the old behaviour
inherit from both.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
E501 line too long (87 > 79 characters) |
reviewbot |
Revision 2 (+5 -3)