flake8
passed.
JSHint
passed.
Render only consent form when user has pending consent decisions
Review Request #9974 — Created May 23, 2018 and submitted
When a user has pending consent decisions or have not accepted the policy
requirements (if set), the My Account page will only render the privacy
form. This is to prevent users from navigating to another page and
failing to complete the form.Additionally, if a user is redirected to this form to complete consent
decisions, they will be redirected to the original page once they have
completed them.
- Ran unit tests.
- Manually tested form submission and was redirected correctly.
| Description | From | Last Updated |
|---|---|---|
|
Typos in the description: "decicions" -> "decisions". The first line might read better as: When a user has pending consent … |
 chipx86
|
|
|
These can be combined to one line. |
chipx86
|
|
|
I think this would be better inversed: if not siteconfig.get(...): return False # Rest here. |
chipx86
|
Change Summary:
Only redirect when the URL is truthy.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+314 -20) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Fix typo
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+314 -20) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Typos in the description: "decicions" -> "decisions".
The first line might read better as:
When a user has pending consent decisions or have not accepted the policy requirements (if set), the My Account page ... -
-
reviewboard/accounts/privacy.py (Diff revision 3) I think this would be better inversed:
if not siteconfig.get(...): return False # Rest here.
Change Summary:
Addressed feedback.
Description: |
|
|||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+313 -20) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Fix unit tests to use new redirect URL
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+315 -22) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.