Render only consent form when user has pending consent decisions

Review Request #9974 — Created May 23, 2018 and submitted

brennie
Review Board
release-3.0.x
9973, 9972
144be98...
reviewboard

When a user has pending consent decisions or have not accepted the policy
requirements (if set), the My Account page will only render the privacy
form. This is to prevent users from navigating to another page and
failing to complete the form.

Additionally, if a user is redirected to this form to complete consent
decisions, they will be redirected to the original page once they have
completed them.

  • Ran unit tests.
  • Manually tested form submission and was redirected correctly.
Description From Last Updated

Typos in the description: "decicions" -> "decisions". The first line might read better as: When a user has pending consent ...

chipx86chipx86

These can be combined to one line.

chipx86chipx86

I think this would be better inversed: if not siteconfig.get(...): return False # Rest here.

chipx86chipx86
brennie
brennie
chipx86
  1. 
      
  2. Typos in the description: "decicions" -> "decisions".

    The first line might read better as:

    When a user has pending consent decisions or have not accepted the policy requirements (if set), the My Account page ...
    
  3. reviewboard/accounts/decorators.py (Diff revision 3)
     
     
     

    These can be combined to one line.

  4. reviewboard/accounts/privacy.py (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    I think this would be better inversed:

    if not siteconfig.get(...):
        return False
    
    # Rest here.
    
  5. 
      
brennie
brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (f2abd8f)
Loading...