- Download Diff

Summary:

Allow ConfigPageForms to return responses in save()

Review Request #9973 — Created May 23, 2018 and submitted May 24, 2018, 12:38 a.m.

Information
Owner:	brennie
Repository:	Djblets
Branch:	release-1.0.x
Bugs:
Depends On:
Blocks:	9974
Commit:	831b417...
Reviewers
Groups:	djblets
People:

Description

ConfigPageForms can now return an HttpResponse in their save

method, which allows them to specify a response to return. This allows

individual forms to specify, e.g., custom redirects.

Testing Done

Used with an upcoming Review Board change.

Issues

Description	From	Last Updated
Typo in the description: "an response" -> "a response"	chipx86	May 24, 2018, 12:14 a.m.
Can you add docs for save() that specifies this as an option?	chipx86	May 24, 2018, 12:16 a.m.
F821 undefined name 'HttpResponse'	reviewbot	May 23, 2018, 5 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/configforms/views.py (Diff revision 1)
Show all issues
```
F821 undefined name 'HttpResponse'
```

Commit:

-	16b451cc80e8585be18d5b5a525f34b5d6f23383
+	75fc485d3aa93a25db6a482ca96d3f370c4d57a8

Diff:

Revision 2 (+6 -2)

Show changes

djblets/configforms/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Show all issues

Typo in the description: "an response" -> "a response"

Show all issues

Can you add docs for save() that specifies this as an option?

Change Summary:

Addressed feedback

Description:

		`ConfigPageForm`s can now return an `HttpResponse` in their `save`
~		method, which allows them to specify an response to return. This allows
	~	method, which allows them to specify a response to return. This allows
		individual forms to specify, e.g., custom redirects.

Commit:

-	75fc485d3aa93a25db6a482ca96d3f370c4d57a8
+	831b4171114b6ef390afe87ca3ba49080bd7708a

Diff:

Revision 3 (+12 -2)

Show changes

	djblets/configforms/forms.py
	djblets/configforms/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (e6520cc)

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Allow ConfigPageForms to return responses in save()

flake8

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Description:

Commit:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: