flake8
passed.
JSHint
passed.
Render only consent form when user has pending consent decisions
Review Request #9974 — Created May 23, 2018 and submitted
When a user has pending consent decisions or have not accepted the policy
requirements (if set), the My Account page will only render the privacy
form. This is to prevent users from navigating to another page and
failing to complete the form.Additionally, if a user is redirected to this form to complete consent
decisions, they will be redirected to the original page once they have
completed them.
- Ran unit tests.
- Manually tested form submission and was redirected correctly.
| Description | From | Last Updated |
|---|---|---|
|
Typos in the description: "decicions" -> "decisions". The first line might read better as: When a user has pending consent … |
 chipx86
|
|
|
These can be combined to one line. |
chipx86
|
|
|
I think this would be better inversed: if not siteconfig.get(...): return False # Rest here. |
chipx86
|
- Change Summary:
-
Only redirect when the URL is truthy.
- Commit:
-
f6b3e66e3a6771a30ecae74ca6b1e3227b19cdb9a49b44155c0f0d245f2060962ace78a67ebc79d7
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Fix typo
- Commit:
-
a49b44155c0f0d245f2060962ace78a67ebc79d78b0b4630b52084083b37343fb9212d0094b3ab49
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed feedback.
- Description:
-
~ When a user has pending consent decicions or (if a privacy policy and/or
~ a terms of service set) they have rejected the the policy requirement, ~ the my account page will only render the privacy form. This is to ~ prevent users from navigating to another page and failing to complete ~ When a user has pending consent decisions or have not accepted the policy
~ requirements (if set), the My Account page will only render the privacy ~ form. This is to prevent users from navigating to another page and ~ failing to complete the form. - the form. Additionally, if a user is redirected to this form to complete consent
decisions, they will be redirected to the original page once they have completed them. - Commit:
-
8b0b4630b52084083b37343fb9212d0094b3ab4904cbb54d0cc3f2ee3abac984af4b3671fb2f0da8
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.