Require validation for DiffCommits when posting
Review Request #9920 — Created May 9, 2018 and submitted — Latest diff uploaded
We now require that diffs for an entire series of commits be validated
before posting to the
DraftDiffCommitResource. Validation is performed
by making a series of
POSTrequests to the
ValidateDiffCommitResource, each of which returns validation data to
be included in the next request. The validation data from each request
to the validation resource must then be used to
This ensures that we do not upload broken diffs and also allows us to
upload more complex commit series. Previously, only linear commit series
where each commit modified different files were capable of being
uploaded. Now all linear commit series can be uploaded.
Posted /r/9609/ through to this commit to a single review request.
Ran unit tests.