• 
      

    Update to the latest jQuery/jQuery UI.

    Review Request #9713 — Created March 1, 2018 and submitted

    Information

    Djblets
    release-2.0.x
    9892cd1...

    Reviewers

    This change updates Djblets to use the latest versions of jQuery and
    jQuery UI. The changes here are pretty straightforward:

    • bind and unbind have been removed in favor of their indentical and
      better-named on and off.
    • A change to event propagation made it so the DOMSubtreeModified
      handler inside ModalBox was causing an infinite recursion. The
      recommended way to do this sort of thing these days is with a
      MutationObserver, so I've ported the code over to use that.
    • The way that widget data is named changed, so the data key for
      the modal box changed from modalBox to uiModalBox.

    This also includes a fix for the backbone JS template to update to the
    latest version of that, which doesn't have any impact on code that
    uses it.

    • Ran Review Board's js-tests suite.
    • Tested inline editors and the modal box.
    Description From Last Updated

    No trailing comma (this isn't an ES6 file).

    chipx86chipx86

    Wanna change to single quote strings in these files while here?

    chipx86chipx86

    This should probably be in the other change.

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      No trailing comma (this isn't an ES6 file).

    3. Show all issues

      Wanna change to single quote strings in these files while here?

    4. djblets/util/templates/js/backbone.html (Diff revision 1)
       
       
      Show all issues

      This should probably be in the other change.

      1. Oh that's Review Board only.

        Were there any Backbone changes needed in Djblets for the options stuff? If not, maybe update the summary/description to just mention Backbone too.

      2. No other changes necessary. Djblets has very few backbone things.

    5. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (78ee1ac)