Cleanup user creation in tests
Review Request #9458 — Created Dec. 19, 2017 and submitted
We now are always careful to provide an e-mail to users in tests. Also,
calls have been updated to useUser.objects.create_userover
User.objects.createwhere appropriate. This was prompted by a change
in Djblets (see https://reviews.reviewboard.org/r/9445/) which started
causing unit test failures due toUsers without e-mail addresses
being serialized. So to be extra safe, I've gone in and added e-mail
addresses to all calls that were lacking them.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
The description doesn't tell me the "why" of this. What's this solving? |
 chipx86
|
|
|
E127 continuation line over-indented for visual indent |
 reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
user22? not user1? |
 david
|
- Commit:
-
af52c8315ebbcf1ef62b31e204128ef4163e2b171fa587a16b6c338969da9067cccf2bf12064c671
- Diff:
-
Revision 2 (+234 -148)
Checks run (2 succeeded)
- Commit:
-
1fa587a16b6c338969da9067cccf2bf12064c671879fdfdb90f7008e3fb5e2ca9330d6f2372fd956
- Diff:
-
Revision 3 (+234 -148)
Checks run (2 succeeded)
- Description:
-
We now are always careful to provide an e-mail to users in tests. Also,
calls have been updated to use User.objects.create_userover~ User.objects.createwhere appropriate.~ User.objects.createwhere appropriate. This was prompted by a change+ in Djblets (see https://reviews.reviewboard.org/r/9445/) which started + causing unit test failures due to Users without e-mail addresses+ being serialized. So to be extra safe, I've gone in and added e-mail + addresses to all calls that were lacking them.