Cleanup user creation in tests

Review Request #9458 - Created Dec. 19, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
879fdfd...
reviewboard

We now are always careful to provide an e-mail to users in tests. Also,
calls have been updated to use User.objects.create_user over
User.objects.create where appropriate. This was prompted by a change
in Djblets (see https://reviews.reviewboard.org/r/9445/) which started
causing unit test failures due to Users without e-mail addresses
being serialized. So to be extra safe, I've gone in and added e-mail
addresses to all calls that were lacking them.

Ran unit tests.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Barret Rennie
David Trowbridge
  1. 
      
  2. user22? not user1?

  3. 
      
Barret Rennie
Christian Hammond
  1. 
      
  2. The description doesn't tell me the "why" of this. What's this solving?

  3. 
      
Barret Rennie
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (3b34522)
Loading...