flake8
passed.
JSHint
passed.
Always lowercase and strip e-mail addresses for gravatar URL computation
Review Request #9445 — Created Dec. 15, 2017 and submitted
| Information | |
|---|---|
| brennie | |
| Djblets | |
| release-1.0.x | |
| f01c6bb... | |
| Reviewers | |
| djblets | |
We now always strip whitespace and lowercase e-mails inside
get_gravatar_url_for_email, instead of having the logic inside of
get_gravatar_url. This will ensure that e-mail hashes are always
generated correctly.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
One group, and alphabetical. |
 chipx86
|
|
|
We should normalize first, and then check if email is falsy (instead of just None). |
chipx86
|
|
|
This can be combined. |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
Ending paren should be on the previous line. Same with others further down. |
chipx86
|
|
|
Can you make this one line? |
chipx86
|
|
|
Ending paren should be on the last attribute, which shouldn't have a comma. These can also start right after create_user(. … |
chipx86
|
-
-
-
djblets/gravatars/__init__.py (Diff revision 1) We should normalize first, and then check if email is falsy (instead of just
None). -
-
-
djblets/gravatars/tests.py (Diff revision 1) Ending paren should be on the previous line.
Same with others further down.
-
-
djblets/gravatars/tests.py (Diff revision 1) Ending paren should be on the last attribute, which shouldn't have a comma.
These can also start right after
create_user(.Same with calls below.
Change Summary:
Addressed Christian's issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+75 -6) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
