Port file attachment views to ES6 and InlineEditorView.

Review Request #9444 — Created Dec. 15, 2017 and submitted

Information

Review Board
master
97723fd...

Reviewers

This change ports the last couple of file attachment related views (the
revision selector view and thumbnail view) to ES6. While I was working
on the thumbnail view, I also ported it to use the new InlineEditorView
for captions.

  • Ran js-tests.
  • Manually tested caption editing in the file attachment thumbnails.
Description From Last Updated

The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we …

chipx86chipx86

Same here.

chipx86chipx86

"Array"

chipx86chipx86

We should probably use listenTo here

chipx86chipx86

Line is too long.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we want to move to dedent here.

  3. reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Same here.

  4. Show all issues

    "Array"

  5. Show all issues

    We should probably use listenTo here

  6. Show all issues

    Line is too long.

  7. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (93cd97d)