Summary

Port file attachment views to ES6 and InlineEditorView.

Review Request #9444 — Created Dec. 15, 2017 and submitted Jan. 15, 2018, 8:42 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

97723fd...

Reviewers

Groups

reviewboard

People

Description

This change ports the last couple of file attachment related views (the
revision selector view and thumbnail view) to ES6. While I was working
on the thumbnail view, I also ported it to use the new InlineEditorView
for captions.

Testing Done


Ran js-tests.
Manually tested caption editing in the file attachment thumbnails.

Issues

Description	From	Last Updated
The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we …	chipx86	Jan. 9, 2018, 5:28 p.m.
Same here.	chipx86	Jan. 9, 2018, 5:28 p.m.
"Array"	chipx86	Jan. 9, 2018, 5:26 p.m.
We should probably use listenTo here	chipx86	Jan. 9, 2018, 5:26 p.m.
Line is too long.	chipx86	Jan. 9, 2018, 5:27 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we want to move to dedent here.

reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Same here.

reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
"Array"
```

reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

We should probably use listenTo here

reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Line is too long.
```

Commit:

77834d4ef259880859c76f782649bae5e13b4e44

97723fd68157ee9592fcd3fa30594ea7a69b6486

Diff:

Revision 2 (+259 -228)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js
	reviewboard/static/rb/js/views/fileAttachmentRevisionSelectorView.js
	reviewboard/static/rb/js/views/fileAttachmentRevisionSelectorView.es6.js
	reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
	reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (93cd97d)