Port file attachment views to ES6 and InlineEditorView.

Review Request #9444 — Created Dec. 15, 2017 and submitted

David Trowbridge
Review Board

This change ports the last couple of file attachment related views (the
revision selector view and thumbnail view) to ES6. While I was working
on the thumbnail view, I also ported it to use the new InlineEditorView
for captions.

  • Ran js-tests.
  • Manually tested caption editing in the file attachment thumbnails.
  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Christian Hammond
  2. reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)

    The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we want to move to dedent here.

  3. reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1)

    Same here.

  4. We should probably use listenTo here

David Trowbridge
Christian Hammond
  1. Ship It!
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (93cd97d)