flake8
passed.
JSHint
passed.
Port file attachment views to ES6 and InlineEditorView.
Review Request #9444 — Created Dec. 15, 2017 and submitted
This change ports the last couple of file attachment related views (the
revision selector view and thumbnail view) to ES6. While I was working
on the thumbnail view, I also ported it to use the new InlineEditorView
for captions.
- Ran js-tests.
- Manually tested caption editing in the file attachment thumbnails.
-
-
reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1) The old template carefully didn't introduce newlines in those list items, but it does now. I don't know that we want to move to dedent here.
-
-
-
reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1) We should probably use
listenTohere -
reviewboard/static/rb/js/views/fileAttachmentThumbnailView.es6.js (Diff revision 1) Line is too long.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+259 -228) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.