[WIP] Support for users with red-green colour-blindness

Review Request #9251 - Created Oct. 8, 2017 and updated

Claudia Chen
Review Board
release-3.0.x
e5894a2...
reviewboard, students

[WIP] Users who are red-green colour blind will likely have more difficulty using the diff viewer and reading change descriptions, as we use red for "line removed" and green for "line added". We should have a preference for changing the add & remove colours to another set of colours that are more distinguishable. This preference would apply to anywhere we use this visual metaphor.
A more colourblind-friendly alternative to green is blue.

I've added a new colorblind setting in user preferences and added a colorblind class to be used in diffviewer.



  • 10
  • 0
  • 0
  • 0
  • 10
Description From Last Updated
E501 line too long (80 > 79 characters) Review Bot Review Bot
E501 line too long (81 > 79 characters) Review Bot Review Bot
W391 blank line at end of file Review Bot Review Bot
E501 line too long (80 > 79 characters) Review Bot Review Bot
W293 blank line contains whitespace Review Bot Review Bot
E501 line too long (81 > 79 characters) Review Bot Review Bot
W391 blank line at end of file Review Bot Review Bot
Because we will never care about querying on this field, instead of adding a new model field for this, which ... David Trowbridge David Trowbridge
W291 trailing whitespace Review Bot Review Bot
The first line of docstrings (the summary) should fit on a single line. You can be pretty terse in these ... David Trowbridge David Trowbridge
Claudia Chen
Claudia Chen
Review request changed

Checks run (1 failed, 1 succeeded)

JSHint passed.
flake8 failed.

flake8

David Trowbridge
  1. When making changes to the UI, it's very useful to have screenshots to look at. The best for something like this is to have two: before and after.

  2. reviewboard/accounts/models.py (Diff revision 3)
     
     
     
     
     
     

    Because we will never care about querying on this field, instead of adding a new model field for this, which requires a database evolution, it would be nice to stick the value into the extra_data field (which works a lot like a Python dictionary but serializes to JSON).

    All the other things in here that are model fields existed before we added extra_data.

  3. reviewboard/accounts/models.py (Diff revision 3)
     
     
     

    The first line of docstrings (the summary) should fit on a single line. You can be pretty terse in these and then flesh out the meaning with more paragraphs below.

  4. 
      
Loading...