Add OAuth token management form

Review Request #9083 - Created July 17, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
9074, 9078
82e30aa...
reviewboard

This patch adds a simple form for managing a user's OAuth tokens. They
can currently only revoke them.

This patch also takes into account the styling changes in /r/9074/ and
the rename of the API token page to the Authentication page.

  • Manually tested token deletion with the form. The tokens were
    successfully deleted.
  • Ran JS tests.
  • Ran unit tests.
Loading file attachments...

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
David Trowbridge
  1. 
      
  2. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     

    Typo: "THe"

  3. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     
     
     

    Might be nicer to wrap as:

    for token in (
        AccessToken.objects
        .select_related('application', 'application__local_site')
        .filter(user=self.user)
    )
    
  4. reviewboard/accounts/pages.py (Diff revision 1)
     
     
     

    Undo this change?

  5. I think the paths should be set up correctly so you can just do @import (reference) "djblets/css/config-forms.less".

    We do use relative paths for images from djblets since those are loaded on-demand from /static/.

  6. 
      
Barret Rennie
David Trowbridge
  1. 
      
  2. Testing done seems incomplete.

  3. The posted diff seems to include unrelated changes.

  4. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (64b3190)
Loading...