Refactor config forms LESS to use variables, support empty item lists

Review Request #9074 - Created July 13, 2017 and submitted

Barret Rennie
Djblets
release-0.10.x
9083
c19f466...
djblets

This patch refactors the config forms LESS to use defined variables for
colours. These colours were being used in Review Board's account pages
and this change will allow the colours to be imported (instead of the
current hardcoding that occurs).

The CSS for config forms lists has been slightly tweaked so that they
have the same top and bottom border. Previously, there was no bottom
border on the list -- it was just the border-bottom from the last
element in the list, which uses a different colour from the border-top
of the entire list.

Additionally, support has been added for a new
.config-forms-list-empty element that is intended to be a sibling of
the .config-forms-list. It will only be shown when the list has n
children. This is a generally useful pattern for supporting
placeholders that don't have to be dynamically added and removed from
the page. This is a refactor from a pattern I was using in Review
Board.

Tested with an upcoming change for Review Board.

Loading file attachments...

  • 0
  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Barret Rennie
Barret Rennie
David Trowbridge
  1. 
      
  2. djblets/static/djblets/css/config-forms.less (Diff revision 2)
     
     
     
     
     
     

    Alphabetize?

  3. djblets/static/djblets/css/config-forms.less (Diff revision 2)
     
     
     
     
     
     
     

    Alphabetize?

  4. Two border-bottom lines?

  5. djblets/static/djblets/css/config-forms.less (Diff revision 2)
     
     
     
     
     
     

    Alphabetize?

  6. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. 
      
  2. First sentence in the description is a bit confusing. There's also a typo: "improted"

  3. Can you add screenshots of how this will look in Review Board, before and after?

  4. 
      
Barret Rennie
Christian Hammond
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (5d29895)
Loading...