flake8
passed.
JSHint
passed.
Add OAuth token management form
Review Request #9083 — Created July 17, 2017 and submitted
This patch adds a simple form for managing a user's OAuth tokens. They
can currently only revoke them.This patch also takes into account the styling changes in /r/9074/ and
the rename of the API token page to the Authentication page.
- Manually tested token deletion with the form. The tokens were
successfully deleted. - Ran JS tests.
- Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Testing done seems incomplete. |
 david
|
|
|
The posted diff seems to include unrelated changes. |
david
|
|
|
Typo: "THe" |
david
|
|
|
Might be nicer to wrap as: for token in ( AccessToken.objects .select_related('application', 'application__local_site') .filter(user=self.user) ) |
david
|
|
|
Undo this change? |
david
|
|
|
I think the paths should be set up correctly so you can just do @import (reference) "djblets/css/config-forms.less". We do use … |
david
|
|
|
Add another blank line here? |
david
|
-
-
-
Might be nicer to wrap as:
for token in ( AccessToken.objects .select_related('application', 'application__local_site') .filter(user=self.user) ) -
-
I think the paths should be set up correctly so you can just do
@import (reference) "djblets/css/config-forms.less".We do use relative paths for images from djblets since those are loaded on-demand from /static/.
-
- Change Summary:
-
Addressed David's issues
- Commit:
-
2b12b90f0185683a460ed7241777a5b56e701acf
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
~ Deleted some tokens.
~ - Manually tested token deletion with the form. The tokens were
successfully deleted.
+ - Ran JS tests.
+ - Ran unit tests.
- Manually tested token deletion with the form. The tokens were
- Commit:
-
2b12b90f0185683a460ed7241777a5b56e701acf82e30aa29f1f2c055f1e5e8bf115984786b92534
- Diff:
-
Revision 3 (+231 -56)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.