Revamp the OAuth2 application admin form

Review Request #8987 - Created June 2, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
8986, 8982
9002
reviewboard

The OAuth2 application form now makes use of some new widgets to make
the user experience better. The logic for the form validation has also
been revamped to take into account when validation of the redirect URIs
field fails (since they will no longer be present in the form's cleaned
data).

Manually tested the form.
Ran unit tests.

Loading file attachments...

  • 0
  • 0
  • 14
  • 0
  • 14
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Barret Rennie
Barret Rennie
Barret Rennie
David Trowbridge
  1. 
      
  2. reviewboard/oauth/forms.py (Diff revision 4)
     
     
     

    Blank line before conditional.

  3. reviewboard/oauth/models.py (Diff revision 4)
     
     

    There seems to be a mismatched <?

  4. reviewboard/oauth/tests.py (Diff revision 4)
     
     
     
     

    g before m

  5. 
      
Barret Rennie
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Barret Rennie
Christian Hammond
  1. 
      
  2. reviewboard/oauth/forms.py (Diff revision 6)
     
     
     

    Swap these.

  3. reviewboard/oauth/forms.py (Diff revision 6)
     
     
     

    Blank line between these.

  4. reviewboard/oauth/forms.py (Diff revision 6)
     
     
     
     
     
     
     
     
     

    This can be one statement now.

  5. reviewboard/oauth/models.py (Diff revision 6)
     
     
     
     
     

    I imagine we're doing this because the parent model does clean and we don't want that one to run? It's not entirely clear from the description (context is missing).

  6. reviewboard/oauth/models.py (Diff revision 6)
     
     

    clean -> clean()

  7. reviewboard/oauth/tests.py (Diff revision 6)
     
     
     

    Swap these.

  8. 
      
Christian Hammond
  1. 
      
    1. This has already been addressed, the screenshot just hasn't been updated.

  2. Not very helpful. It's just a repeat of the label. Can you update this to say exactly what this is?

  3. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c950ac6)
Loading...