flake8
failed.
JSHint
passed.
flake8
-
reviewboard/oauth/models.py (Diff revision 1) Show all issues -
Revamp the OAuth2 application admin form
Review Request #8987 — Created June 2, 2017 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-3.0.x | |
|
|
|
| 9002 | |
| Reviewers | |
| reviewboard | |
The OAuth2 application form now makes use of some new widgets to make
the user experience better. The logic for the form validation has also
been revamped to take into account when validation of the redirect URIs
field fails (since they will no longer be present in the form's cleaned
data).
Manually tested the form.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Should be "Client ID" |
 chipx86
|
|
|
Not very helpful. It's just a repeat of the label. Can you update this to say exactly what this is? |
chipx86
|
|
|
W293 blank line contains whitespace |
 reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
Blank line before conditional. |
 david
|
|
|
There seems to be a mismatched <? |
david
|
|
|
g before m |
david
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
Swap these. |
chipx86
|
|
|
Blank line between these. |
chipx86
|
|
|
This can be one statement now. |
chipx86
|
|
|
I imagine we're doing this because the parent model does clean and we don't want that one to run? It's … |
chipx86
|
|
|
clean -> clean() |
chipx86
|
|
|
Swap these. |
chipx86
|
Change Summary:
Add unit tests.
Testing Done: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+150 -9) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/accounts/forms/pages.py (Diff revision 5) E261 at least two spaces before inline comment
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
-
-
reviewboard/oauth/models.py (Diff revision 6) I imagine we're doing this because the parent model does
cleanand we don't want that one to run? It's not entirely clear from the description (context is missing). -
-
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.