Add the ListEditWidget
Review Request #8982 — Created June 1, 2017 and submitted
The
ListEditWidget
provides an interface for editing a delimited
list of values as a list of input fields.
Used this with an upcoming change for Review Board.
Description | From | Last Updated |
---|---|---|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
Col: 73 Missing semicolon. |
![]() |
|
Col: 72 Expected ')' and instead saw ';'. |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
No space between function and () |
|
|
Shouldn't have trailing commas in non-ES6 code. |
|
|
, optional |
|
|
, optional |
|
|
You're using the variable name item in both the inner and outer loops. How about different names? |
|
|
Trailing comma? |
|
|
Missing Args/Returns |
|
|
Trailing whitespace. |
|
|
No spaces around the = |
|
|
We have a default value (empty object) for options. What happens if this is constructed with that default? It looks … |
|
|
Trailing comma? |
|
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
Col: 68 Missing semicolon. |
![]() |
|
Col: 64 Missing semicolon. |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
Can we change this around a little bit so we have: const $entry = $(...) .insertBefore(this._$addBtn); $entry .find(...) .on(...) .end() … |
|
- Change Summary:
-
Added unit tests. Fixed some bugs. Addressed David's feedback.
- Diff:
-
Revision 5 (+469 -1)
- Added Files: