Improve table styling in rendered Markdown

Review Request #8970 — Created May 25, 2017 and submitted

brennie
Djblets
release-0.9.x
8969
4e1d3c5...
djblets

This patch adds some better styling to our rendered Markdown. We now
render vertical borders and emphasize the border that separates headers
from content.

Tested this with /r/8969/


Description From Last Updated

There's also still spacing issues. Looks like too much padding on the table? Any chance of tweaking that to get …

chipx86chipx86

Should use full-length hex color codes. It'd also be nice to use variables for these, so callers can override. (We …

chipx86chipx86

Blank line here.

chipx86chipx86

This can be: tbody tr { &:first-child td { .. } &:last-child td { .. } }

chipx86chipx86
brennie
chipx86
  1. 
      
  2. djblets/static/djblets/css/mixins/markdown.less (Diff revision 1)
     
     
     
     
     
     
     
     

    Should use full-length hex color codes.

    It'd also be nice to use variables for these, so callers can override. (We don't do that everywhere, but it'd be nice to start.)

  3. Blank line here.

  4. djblets/static/djblets/css/mixins/markdown.less (Diff revision 1)
     
     
     
     
     
     
     
     

    This can be:

    tbody tr {
      &:first-child td {
        ..
      }
    
      &:last-child td {
        ..
      }
    }
    
  5. 
      
chipx86
  1. 
      
  2. There's also still spacing issues. Looks like too much padding on the table? Any chance of tweaking that to get the text to not appear to really shift at all?

  3. 
      
brennie
chipx86
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (ad6f4d8)
Loading...