Summary

Enable Markdown table rendering in RB

Review Request #8969 — Created May 25, 2017 and submitted July 6, 2017, 3:57 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

~~8970~~

Commit

e33bec0...

Reviewers

Groups

reviewboard

People

Description

We previously did not have the table extension loaded so tables would
not load. We now have them enabled and tables render.

Testing Done

Edited some markdown with tables and saw they rendered.

Issues

Description	From	Last Updated
I've broken this change. Sorry about that! You'll need to convert this to a full module path for the extension. …	chipx86	July 5, 2017, 2:43 p.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/markdown_utils.py (Diff revision 1)

The issue has been resolved. Show all issues

I've broken this change. Sorry about that!

You'll need to convert this to a full module path for the extension. That'll be a requirement in Python-Markdown 2.7.

brennie June 12, 2017, 4:02 p.m.
```
On 3.0, yes.
```

chipx86 June 20, 2017, 4:47 p.m.

It applies to 2.5 as well, so it's worth doing, keep merges sane.

Summary:

-	Enable table rendering in RB
+	Enable Markdown table rendering in RB

Change Summary:

Addressed Christian's issues.

Commit:

-	f02d3b870893842d6549970023dc66ebfd15e038
+	e33bec0a96c9e900986f7a85c74ffd46d20d4ea4

Diff:

Revision 2 (+1)

Show changes

reviewboard/reviews/markdown_utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (b2dfbe8)