Summary

Improve table styling in rendered Markdown

Review Request #8970 — Created May 25, 2017 and submitted June 27, 2017, 3:05 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Blocks

8969

Commit

4e1d3c5...

Reviewers

Groups

djblets

People

Description

This patch adds some better styling to our rendered Markdown. We now
render vertical borders and emphasize the border that separates headers
from content.

Testing Done

Tested this with /r/8969/

Files

Issues

Description	From	Last Updated
There's also still spacing issues. Looks like too much padding on the table? Any chance of tweaking that to get …	chipx86	June 12, 2017, 3:46 p.m.
Should use full-length hex color codes. It'd also be nice to use variables for these, so callers can override. (We …	chipx86	June 12, 2017, 3:54 p.m.
Blank line here.	chipx86	June 12, 2017, 3:55 p.m.
This can be: tbody tr { &:first-child td { .. } &:last-child td { .. } }	chipx86	June 12, 2017, 3:55 p.m.

flake8 passed.

JSHint passed.

Summary:: Improve table styling
Improve table styling in rendered Markdown
Description:: ~
Improve table styling
~
This patch adds some better styling to our rendered Markdown. We now
+ render vertical borders and emphasize the border that separates headers
+ from content.

djblets/static/djblets/css/mixins/markdown.less (Diff revision 1)

The issue has been resolved. Show all issues

Should use full-length hex color codes.

It'd also be nice to use variables for these, so callers can override. (We don't do that everywhere, but it'd be nice to start.)

djblets/static/djblets/css/mixins/markdown.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line here.
```

djblets/static/djblets/css/mixins/markdown.less (Diff revision 1)

The issue has been resolved. Show all issues

This can be:

tbody tr {
  &:first-child td {
    ..
  }

  &:last-child td {
    ..
  }
}

The issue has been dropped. Show all issues

There's also still spacing issues. Looks like too much padding on the table? Any chance of tweaking that to get the text to not appear to really shift at all?

Diff:

Revision 2 (+32 -2)

Show changes

	djblets/static/djblets/css/mixins/defs.less
	djblets/static/djblets/css/mixins/markdown.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (ad6f4d8)

~		Improve table styling
	~	This patch adds some better styling to our rendered Markdown. We now
	+	render vertical borders and emphasize the border that separates headers
	+	from content.