Summary

Add resources for fetching blobs & blob info

Review Request #8923 — Created May 6, 2017 and submitted May 23, 2017, 10:15 p.m.

Information

Owner

brennie

Repository

gerrit-reviewboard-plugin

Branch

master

Bugs

Depends On

~~8922~~

Blocks

8938

Reviewers

Groups

gerrit-reviewboard-plugin

People

Description

This patch adds two new resources: GetBlobInfo and GetBlobContent.
The former returns whether or not a blob with the given ID exists and
the latter returns the content of a blob with the given ID as base64-
encoded data.

Testing Done

Retrieved a file via the API.
Verified invalid blob IDs, etc. resulted in a 404.

Issues

Description	From	Last Updated
This can be final.	david	May 23, 2017, 5:46 a.m.
Can be final.	david	May 23, 2017, 5:46 a.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Judicious use of final.

Diff:

Revision 2 (+211)

Show changes

	src/main/java/org/reviewboard/rbgerrit/FileResource.java
	src/main/java/org/reviewboard/rbgerrit/FilesCollection.java
	src/main/java/org/reviewboard/rbgerrit/GetFileContent.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Rebase

Diff:

Revision 3 (+210)

Show changes

	src/main/java/org/reviewboard/rbgerrit/FileResource.java
	src/main/java/org/reviewboard/rbgerrit/FilesCollection.java
	src/main/java/org/reviewboard/rbgerrit/GetFileContent.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

Add a resource for fetching blobs

Add resources for fetching blobs & blob info

Description:

~		The `GetFileContent` resource, available via
~		`a/projects/<projectName>/files/<blobId>/content`, returns the content
~		of a blob with the given ID as base64 encoded data. If the given ID
~		does not correspond to an object in the index, or the object it refers
	~	This patch adds two new resources: `GetBlobInfo` and `GetBlobContent`.
	~	The former returns whether or not a blob with the given ID exists and
	~	the latter returns the content of a blob with the given ID as base64-
	~	encoded data.
-		to is not a blob, it will return a 404 Not Found.

Testing Done:

~		Retrieved a file via the API.
	~	Retrieved a file via the API.
	+	Verified invalid blob IDs, etc. resulted in a 404.

Diff:

Revision 4 (+268)

Show changes

	src/main/java/org/reviewboard/rbgerrit/BlobResource.java
	src/main/java/org/reviewboard/rbgerrit/BlobsCollection.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobContent.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobInfo.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Depends On:: ~~8922 - Add a resource for retrieving a list of commits~~

Change Summary:

Formatting & logging

Diff:

Revision 5 (+286)

Show changes

	src/main/java/org/reviewboard/rbgerrit/BlobResource.java
	src/main/java/org/reviewboard/rbgerrit/BlobsCollection.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobContent.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobInfo.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

src/main/java/org/reviewboard/rbgerrit/GetBlobContent.java (Diff revision 5)
The issue has been resolved. Show all issues
```
This can be final.
```
src/main/java/org/reviewboard/rbgerrit/GetBlobContent.java (Diff revision 5)
The issue has been resolved. Show all issues
```
Can be final.
```

Change Summary:

final final final final final

Diff:

Revision 6 (+286)

Show changes

	src/main/java/org/reviewboard/rbgerrit/BlobResource.java
	src/main/java/org/reviewboard/rbgerrit/BlobsCollection.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobContent.java
	src/main/java/org/reviewboard/rbgerrit/GetBlobInfo.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed