Add a resource for retrieving a list of commits

Review Request #8922 - Created May 5, 2017 and submitted

Barret Rennie
gerrit-reviewboard-plugin
master
8920
8923
gerrit-reviewboard-plugin

The CommitListResource, available at
a/projects/<projectName>/all-commits/, returns a list of commit
information entries about the first N (default 30) commits on a
branch. It also supports starting at a specific commit for
pagination support.

Hit the API with ?limit and ?start queries and saw the correct
results.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Barret Rennie
Barret Rennie
Barret Rennie
David Trowbridge
  1. 
      
  2. Inconsistent spacing around =s. Shouldn't have any spaces, I think.

  3. Inconsistent spacing around =s. Shouldn't have any spaces, I think.

    Also, CNT?

    1. It was short for COUNT. :/

  4. Should we be doing some kind of logging rather than just saying to print to console?

  5. What happens if the commit has no parents?

    1. The walk that generates these commits (see line 94, 139--) ensures that each commit has exactly a single parent.

    2. In that case, rather than having a conditional, can we assert?

    3. Ping on this?

  6. 
      
Barret Rennie
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Loading...