Add support for Gerrit as a hosting service

Review Request #8938 - Created May 10, 2017 and updated

Barret Rennie
Review Board
release-2.5.x
8923, 8913
reviewboard

This patch adds support for Gerrit as a hosting service when the Gerrit
server has the gerrit-reviewboard plugin installed (see: /r/8919/ et
al.). The Gerrit API does not provide sufficient information (e.g., it
cannot retrieve files by blob ID, cannot list commits, and cannot
retrieve diffs for arbitrary commits not related to changes), so we rely
on the plugin for this. This hosting service will check for the plugin's
presence via the Gerrit API and will not allow repositories without it
installed.

  • Tested post-commit review request creation.
  • Tested rbt post with a Gerrit-backed repository.
  • Ran unit tests.
Loading file attachments...

  • 0
  • 16
  • 14
  • 30
Description From Last Updated
Barret Rennie
Barret Rennie
Barret Rennie
Review request changed
David Trowbridge
  1. 
      
  2. reviewboard/hostingsvcs/gerrit.py (Diff revision 3)
     
     
     
     
     
     
     
     
     
     

    t comes after s.

  3. reviewboard/hostingsvcs/gerrit.py (Diff revision 3)
     
     
     

    Wrap in parens instead of using the continuation character.

    1. I discovered pycharm auto imports while doing the java stuff but it doesnt do it so pretty.

  4. reviewboard/hostingsvcs/gerrit.py (Diff revision 3)
     
     

    Wrap this error in _()?

  5. reviewboard/hostingsvcs/gerrit.py (Diff revision 3)
     
     

    typo: ot

  6. reviewboard/hostingsvcs/gerrit.py (Diff revision 3)
     
     
     
     
     

    e should be passed in as another arg, since the logger functions do their own format operation.

  7. Can you add two blank lines between these?

  8. Undo this change.

  9. Undo this change.

  10. Undo this change.

  11. Can you add two blank lines between these?

Loading...