Add a resource for retrieving diffs

Review Request #8920 — Created May 5, 2017 and submitted

brennie
gerrit-reviewboard-plugin
master
8919
8922
gerrit-reviewboard-plugin

The DiffResource, available at
a/projects/<projectName>/commits/<sha>/diff/, yields the diff of the
commit with the given sha. Due to limitations within the JGit library,
we are only able to compute diffs for commits which have a single
parent.

Hit the API and saw the diff returned.

Description From Last Updated

Can we call this DIFF_MIMETYPE?

daviddavid

Indentation is kind of wacky here.

daviddavid

final IOException?

daviddavid
brennie
brennie
brennie
brennie
david
  1. 
      
  2. Can we call this DIFF_MIMETYPE?

  3. Indentation is kind of wacky here.

    1. IntelliJ IDEA did this :/ its indented two tabs from the r. What is our style guide here? Single tab?

    2. In our TFS adapter code I did 4-space indentation everywhere, like we do for python and JS code.

  4. 
      
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Loading...