Summary

Add a resource for retrieving diffs

Review Request #8920 — Created May 5, 2017 and submitted May 23, 2017, 12:37 p.m.

Information

Owner

brennie

Repository

gerrit-reviewboard-plugin

Branch

master

Bugs

Depends On

~~8919~~

Blocks

8922

Reviewers

Groups

gerrit-reviewboard-plugin

People

Description

The DiffResource, available at
a/projects/<projectName>/commits/<sha>/diff/, yields the diff of the
commit with the given sha. Due to limitations within the JGit library,
we are only able to compute diffs for commits which have a single
parent.

Testing Done

Hit the API and saw the diff returned.

Issues

Description	From	Last Updated
Can we call this DIFF_MIMETYPE?	david	May 11, 2017, 8:50 a.m.
Indentation is kind of wacky here.	david	May 11, 2017, 8:55 a.m.
final IOException?	david	May 11, 2017, 8:55 a.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Judicious use of final.

Description:

		The `DiffResource`, available at
~		`a/projects/<projectName>/commits/<sha>/gerrit-reviewboard~diff/`,
~		yields the diff of the commit with the given sha. Due to limitations
~		within the JGit library, we are only able to compute diffs for commits
~		which have a single parent.
	~	`a/projects/<projectName>/commits/<sha>/diff/`, yields the diff of the
	~	commit with the given sha. Due to limitations within the JGit library,
	~	we are only able to compute diffs for commits which have a single
	~	parent.

Diff:

Revision 2 (+90)

Show changes

	src/main/java/org/reviewboard/rbgerrit/DiffResource.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Return diffs as text/x-patch instead of JSON strings.

Diff:

Revision 3 (+93)

Show changes

	src/main/java/org/reviewboard/rbgerrit/DiffResource.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Judicious use of final.

Diff:

Revision 4 (+93)

Show changes

	src/main/java/org/reviewboard/rbgerrit/DiffResource.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Change Summary:

Remove unused imports

Diff:

Revision 5 (+91)

Show changes

	src/main/java/org/reviewboard/rbgerrit/DiffResource.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

src/main/java/org/reviewboard/rbgerrit/DiffResource.java (Diff revision 5)
The issue has been resolved. Show all issues
```
Can we call this DIFF_MIMETYPE?
```

src/main/java/org/reviewboard/rbgerrit/DiffResource.java (Diff revision 5)

The issue has been resolved. Show all issues

Indentation is kind of wacky here.

brennie May 10, 2017, 10:54 p.m.

IntelliJ IDEA did this :/ its indented two tabs from the r. What is our style guide here? Single tab?

david May 10, 2017, 10:57 p.m.

In our TFS adapter code I did 4-space indentation everywhere, like we do for python and JS code.

src/main/java/org/reviewboard/rbgerrit/DiffResource.java (Diff revision 5)
The issue has been resolved. Show all issues
```
final IOException?
```

Diff:

Revision 6 (+96)

Show changes

	src/main/java/org/reviewboard/rbgerrit/DiffResource.java
	src/main/java/org/reviewboard/rbgerrit/Module.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed