Deprecate the type argument of review request signals
Review Request #8896 — Created April 12, 2017 and submitted — Latest diff uploaded
This patch deprecates the
type
argument of thereview_request_closed
andreview_request_closing
signals, due to shadowing thetype
builtin. We still provide thetype
argument, but it is wrapped in a
lazy object that will emit a warning when casted to a unicode string. We
now include theclose_type
argument which takes the place of the old
type
argument. Usages and unit tests have been updated for this new
behaviour.
Ran unit tests.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
orig
1
2
3
4
reviewboard/signals.py |
---|
reviewboard/notifications/webhooks.py |
---|
reviewboard/notifications/email/callbacks.py |
---|
reviewboard/notifications/email/decorators.py |
---|
reviewboard/reviews/signals.py |
---|
reviewboard/reviews/models/review_request.py |
---|
reviewboard/reviews/tests/test_signals.py |
---|