Do not shadow format builtin in e-mail preview views

Review Request #8895 — Created April 12, 2017 and submitted

brennie
Review Board
release-3.0.x
8894
8896
reviewboard

The e-mail preview views were shadowing the format builtin via a
argument which indicated the format to render the e-mail as: plain text
or HTML. In order to not shadow format, it has been renamed
message_format and all URLs and tests have been updated appropriately.

In addition, the preview password change e-mail view has been updated to
use message_format from the URL instead of extracting it from
request.GET.

Ran unit tests.

Description From Last Updated

Do you mean the format builtin?

chipx86chipx86
david
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Do you mean the format builtin?

  3. 
      
brennie
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7a502be)
Loading...