Deprecate the type argument of review request signals

Review Request #8896 - Created April 12, 2017 and updated

Barret Rennie
Review Board
release-3.0.x
8895
8897
reviewboard

This patch deprecates the type argument of the review_request_closed
and review_request_closing signals, due to shadowing the type
builtin. We still provide the type argument, but it is wrapped in a
lazy object that will emit a warning when casted to a unicode string. We
now include the close_type argument which takes the place of the old
type argument. Usages and unit tests have been updated for this new
behaviour.

Ran unit tests.

  • 1
  • 7
  • 0
  • 8
Description From Last Updated
This would be great in Djblets :) Christian Hammond Christian Hammond
Barret Rennie
Barret Rennie
Barret Rennie
David Trowbridge
Barret Rennie
Christian Hammond
Barret Rennie
Review request changed

Checks run (2 succeeded, 1 failed with error)

JSHint passed.
Pyflakes passed.
PEP8 Style Checker internal error.
Loading...