Summary

Do not shadow format builtin in e-mail preview views

Review Request #8895 — Created April 12, 2017 and submitted May 22, 2017, 10:39 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8894~~

Blocks

8896

Reviewers

Groups

reviewboard

People

Description

The e-mail preview views were shadowing the format builtin via a
argument which indicated the format to render the e-mail as: plain text
or HTML. In order to not shadow format, it has been renamed
message_format and all URLs and tests have been updated appropriately.

In addition, the preview password change e-mail view has been updated to
use message_format from the URL instead of extracting it from
request.GET.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Do you mean the format builtin?	chipx86	April 24, 2017, 6:04 p.m.

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues
```
Do you mean the format builtin?
```

Description:: ~
The e-mail preview views were shadowing the preview builtin via a
~
The e-mail preview views were shadowing the format builtin via a
argument which indicated the format to render the e-mail as: plain text
or HTML. In order to not shadow format, it has been renamed
message_format and all URLs and tests have been updated appropriately.

In addition, the preview password change e-mail view has been updated to
use message_format from the URL instead of extracting it from
request.GET.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (7a502be)

~		The e-mail preview views were shadowing the `preview` builtin via a
	~	The e-mail preview views were shadowing the `format` builtin via a
		argument which indicated the format to render the e-mail as: plain text
		or HTML. In order to not shadow `format`, it has been renamed
		`message_format` and all URLs and tests have been updated appropriately.

		In addition, the preview password change e-mail view has been updated to
		use `message_format` from the URL instead of extracting it from
		`request.GET`.