Fix errors when saving a group that has inactive members.

Review Request #8820 — Created March 16, 2017 and submitted

Information

Review Board
release-2.5.x
48df922...

Reviewers

The new user selector in the group admin page was filtering to only allow
selecting active users. This meant that if a group had existing users who had
been marked as inactive, trying to save any modifications to it would fail
until those users were removed. There's no good reason to do this, so I've
removed the filter from the field queryset.

Created a group with a few users and marked one of those users as inactive. Saw
that before the change, saving the group would fail, and after, it succeds.

Description From Last Updated

I swear this was fixed somewhere already... Didn't we have a student on this?

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/forms.py
    
    
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    I swear this was fixed somewhere already... Didn't we have a student on this?

    1. We had marked the bug as EasyFix but nobody had picked it up.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (6897531)
Loading...