4513: User selector in the Group configuration breaks for non-active users

chipx86
david
david

What version are you running?

2.5.7

What's the URL of the page containing the problem?

/admin/db/reviews/group/ID/

What steps will reproduce the problem?

  1. Add another user to a group.
  2. Go into the Users part of the database viewer, edit a user, and uncheck the "Active" checkbox. Save.
  3. Try to save the group again.

What is the expected output? What do you see instead?

This will fail with "Select a valid choice. ID is not one of the available choices."

This happens because the queryset for GroupForm uses is_active=True, preventing any users in the list who are inactive from being saved.

We should remove that and make sure inactive users in the list can be saved (with a unit test proving this).

chipx86
#1 chipx86
  • -New
    +Confirmed
  • +Release-2.5.x
  • +Component:Admin
    +EasyFix
david
#2 david
  • -Confirmed
    +PendingReview
  • +david
david
#3 david

Fixed in release-2.5.x (6897531). This will ship in 2.5.10. Thanks!

  • -PendingReview
    +Fixed