Do not render the avatar service form when there are no services

Review Request #8729 - Created Feb. 8, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
8725, 8727, 8726
reviewboard

We now take into account the number of enabled services when calculating
the visibility of the avatar settings form. In addition, due to recent
changes to Djblets (see /r/8726 and /r/8728), we no longer have to add or
remove the avatar services form to the configuration page (due to
ConfigPageForm.is_visible() evlauating to False causing the form to
not render). This allows the logic of the avatar services admin form to
be simplified.

Viewed account page with avatars enabled but no enabled services. The
page did not raise an exception and the form was not visible.

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Review Bot
Barret Rennie
Review Bot
David Trowbridge
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (980df4f)
Loading...